Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Designer: "Add options" dialog doesn't reset when canceling: #14110 issue fixed #14117

Merged
merged 3 commits into from Mar 30, 2018

Conversation

Projects
None yet
2 participants
@Piyush3079
Copy link
Contributor

Piyush3079 commented Mar 23, 2018

Designer: "Add options" dialog doesn't reset when canceling: #14110 issue fixed

Signed-off-by: Piyush Vijay piyushvijay.1997@gmail.com

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

Piyush3079 added some commits Mar 23, 2018

Designer: "Add options" dialog doesn't reset when canceling: #14110 i…
…ssue fixed

Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
Designer: Add option dialogue error handling needs to be modified #14126


Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 29, 2018

Codecov Report

Merging #14117 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master   #14117      +/-   ##
============================================
+ Coverage     55.44%   55.44%   +<.01%     
+ Complexity    14374    14373       -1     
============================================
  Files           494      494              
  Lines         70613    70617       +4     
============================================
+ Hits          39148    39151       +3     
- Misses        31465    31466       +1

@mauriciofauth mauriciofauth merged commit 6700b2d into phpmyadmin:master Mar 30, 2018

6 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
DCO All commits have a DCO sign-off from the author
Scrutinizer Analysis: 3 new issues – Tests: passed
Details
codecov/patch 100% of diff hit (target 55.44%)
Details
codecov/project 55.44% (+<.01%) compared to 8b04a2b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mauriciofauth mauriciofauth self-assigned this Mar 30, 2018

@mauriciofauth

This comment has been minimized.

Copy link
Member

mauriciofauth commented Mar 30, 2018

Merged, thanks for your contribution!

@mauriciofauth mauriciofauth added this to the 4.8.0 milestone Mar 30, 2018

mauriciofauth added a commit that referenced this pull request Mar 30, 2018

Designer: "Add options" dialog doesn't reset when canceling: #14110 i…
…ssue fixed (#14117)

* Designer: "Add options" dialog doesn't reset when canceling: Fix #14110
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

* Designer: Add option dialogue error handling needs to be modified Fix #14126
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
(cherry picked from commit 6700b2d)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>

@Piyush3079 Piyush3079 deleted the Piyush3079:PMA_14410 branch Apr 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.