Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AUTO_INCREMENT error when only exporting table structure in database-level exports; issue #14066 #14119

Merged
merged 2 commits into from May 16, 2018

Conversation

@meteorlxy
Copy link
Contributor

@meteorlxy meteorlxy commented Mar 24, 2018

Fix #14066

meteorlxy added 2 commits Mar 24, 2018
… database-level exports

Signed-off-by: Xinyu Liu <meteor.lxy@foxmail.com>
…base-level exports; issue #14066

Signed-off-by: Xinyu Liu <meteor.lxy@foxmail.com>
@meteorlxy meteorlxy force-pushed the meteorlxy:patch-tmp branch from 89f3e17 to f1fa924 Mar 24, 2018
@mauriciofauth mauriciofauth merged commit 3c12c9e into phpmyadmin:master May 16, 2018
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Codacy/PR Quality Review Good work! A positive pull request.
Details
DCO All commits have a DCO sign-off from the author
Scrutinizer 1 new issues, 1 updated code elements
Details
@mauriciofauth mauriciofauth self-assigned this May 16, 2018
@mauriciofauth mauriciofauth added this to the 4.8.1 milestone May 16, 2018
@mauriciofauth
Copy link
Member

@mauriciofauth mauriciofauth commented May 16, 2018

Merged, thanks for your contribution!

@barrystaes

This comment has been minimized.

Copy link

@barrystaes barrystaes commented on 298ef43 Dec 12, 2018

I found that in PMA 4.8.4 its not possible to export all procedures here without having to exporting table structure. This worked fine in 4.7.0 for example.

@meteorlxy I believe this UI tweak introduced this problem.

For example, the option "add CREATE PROCEDURE / FUNCTION / EVENT statements" disappears when someone does not want to export table structure or data. And when this is checked, the "add DROP" checkbox also needs to be visible.

A workaround would be the export procedures button in the procedures list page, but this does not output to a file and does not even sorts the procedures making it unfit for version control use.

This comment has been minimized.

Copy link
Member

@williamdes williamdes replied Dec 15, 2018

@barrystaes Can you open an issue ?

This comment has been minimized.

Copy link

@barrystaes barrystaes replied Dec 19, 2018

@williamdes ok i created issue #14796

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants