New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove inline styles from Relation.php #14141
Conversation
Signed-off-by: Mohit Jawanjal <mohit.jawanjal@imnica.com>
libraries/classes/Relation.php
Outdated
@@ -101,16 +101,16 @@ public function getRelationsParamDiagnostic(array $cfgRelation) | |||
$retval = '<br>'; | |||
|
|||
$messages = array(); | |||
$messages['error'] = '<span style="color:red"><strong>' | |||
$messages['error'] = '<span class="span_color_red"><strong>' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use the caution
class here. See:
phpmyadmin/themes/pmahomme/css/common.css.php
Lines 1026 to 1028 in 695fe3a
span.caution { | |
color: #FF0000; | |
} |
libraries/classes/Relation.php
Outdated
. _pgettext('Correctly working', 'OK') | ||
. '</strong></span>'; | ||
|
||
$messages['enabled'] = '<span style="color:green">' . __('Enabled') . '</span>'; | ||
$messages['disabled'] = '<span style="color:red">' . __('Disabled') . '</span>'; | ||
$messages['enabled'] = '<span class="span_color_green">' . __('Enabled') . '</span>'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be interesting to use another class name instead of span_color_green
, for example: is_enabled
or success
. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, success would be good. I'll look around for similar classes from the next time :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Once you submit the new changes, we can merge this pull request.
Signed-off-by: Mohit Jawanjal <mohit.jawanjal@imnica.com>
Sorry my git kung-fu is not very good today. :( Going to re-submit it on a different PR. @MauricioFauth Do you think creating a new branch would be a good idea or should I work with master? |
@@ -3434,4 +3437,4 @@ | |||
/* side menu */ | |||
#name-panel { | |||
overflow:hidden; | |||
} | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add the new line at the end of file again?
@@ -3683,4 +3686,4 @@ | |||
/* side menu */ | |||
#name-panel { | |||
overflow:hidden; | |||
} | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add the new line at the end of file again?
@mohitjawanjal You can keep the master branch in this PR, but it is recommended to use a separate branch. |
@@ -1026,6 +1026,9 @@ | |||
span.caution { | |||
color: #FF0000; | |||
} | |||
span.success { | |||
color: green; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line contains trailing whitespace. Could you remove it?
Merged, thanks for your contribution! |
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Related to #12262
Signed-off-by: Mohit Jawanjal mohit.jawanjal@imnica.com
Before submitting pull request, please check that every commit: