Remove inline styles from Relation.php #14141
Conversation
Signed-off-by: Mohit Jawanjal <mohit.jawanjal@imnica.com>
| @@ -101,16 +101,16 @@ public function getRelationsParamDiagnostic(array $cfgRelation) | |||
| $retval = '<br>'; | |||
|
|
|||
| $messages = array(); | |||
| $messages['error'] = '<span style="color:red"><strong>' | |||
| $messages['error'] = '<span class="span_color_red"><strong>' | |||
mauriciofauth
Mar 28, 2018
Member
You can use the caution class here. See:
phpmyadmin/themes/pmahomme/css/common.css.php
Lines 1026 to 1028
in
695fe3a
You can use the caution class here. See:
phpmyadmin/themes/pmahomme/css/common.css.php
Lines 1026 to 1028 in 695fe3a
| . _pgettext('Correctly working', 'OK') | ||
| . '</strong></span>'; | ||
|
|
||
| $messages['enabled'] = '<span style="color:green">' . __('Enabled') . '</span>'; | ||
| $messages['disabled'] = '<span style="color:red">' . __('Disabled') . '</span>'; | ||
| $messages['enabled'] = '<span class="span_color_green">' . __('Enabled') . '</span>'; |
mauriciofauth
Mar 28, 2018
Member
It would be interesting to use another class name instead of span_color_green, for example: is_enabled or success. What do you think?
It would be interesting to use another class name instead of span_color_green, for example: is_enabled or success. What do you think?
mohitjawanjal
Mar 29, 2018
Author
Yup, success would be good. I'll look around for similar classes from the next time :-)
Yup, success would be good. I'll look around for similar classes from the next time :-)
mauriciofauth
Mar 30, 2018
Member
Great! Once you submit the new changes, we can merge this pull request.
Great! Once you submit the new changes, we can merge this pull request.
Signed-off-by: Mohit Jawanjal <mohit.jawanjal@imnica.com>
This comment has been minimized.
This comment has been minimized.
|
This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our Developer guidelines for more information. Offending files: themes/pmahomme/css/common.css.php |
|
Sorry my git kung-fu is not very good today. :( Going to re-submit it on a different PR. @mauriciofauth Do you think creating a new branch would be a good idea or should I work with master? |
| @@ -3434,4 +3437,4 @@ | |||
| /* side menu */ | |||
| #name-panel { | |||
| overflow:hidden; | |||
| } | |||
| } | |||
mauriciofauth
Apr 2, 2018
Member
Could you add the new line at the end of file again?
Could you add the new line at the end of file again?
| @@ -3683,4 +3686,4 @@ | |||
| /* side menu */ | |||
| #name-panel { | |||
| overflow:hidden; | |||
| } | |||
| } | |||
mauriciofauth
Apr 2, 2018
Member
Could you add the new line at the end of file again?
Could you add the new line at the end of file again?
|
@mohitjawanjal You can keep the master branch in this PR, but it is recommended to use a separate branch. |
| @@ -1026,6 +1026,9 @@ | |||
| span.caution { | |||
| color: #FF0000; | |||
| } | |||
| span.success { | |||
| color: green; | |||
mauriciofauth
Apr 2, 2018
Member
This line contains trailing whitespace. Could you remove it?
This line contains trailing whitespace. Could you remove it?
mauriciofauth
merged commit 3178fac
into
phpmyadmin:master
|
Merged, thanks for your contribution! |
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Related to #12262
Signed-off-by: Mohit Jawanjal mohit.jawanjal@imnica.com
Before submitting pull request, please check that every commit: