New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for adding central column, #14139 #14142

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@nulll-pointer
Contributor

nulll-pointer commented Mar 28, 2018

Signed-Off-By: Lakshya arora arora.lakshya123@gmail.com

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
Fix for adding central column, #14139
Signed-Off-By: Lakshya arora <arora.lakshya123@gmail.com>
@codecov

This comment has been minimized.

codecov bot commented Mar 28, 2018

Codecov Report

Merging #14142 into master will not change coverage.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master   #14142   +/-   ##
=========================================
  Coverage     55.44%   55.44%           
  Complexity    14373    14373           
=========================================
  Files           494      494           
  Lines         70616    70616           
=========================================
  Hits          39150    39150           
  Misses        31466    31466

@mauriciofauth mauriciofauth self-assigned this Mar 30, 2018

@mauriciofauth

This comment has been minimized.

Member

mauriciofauth commented Mar 30, 2018

Hello, @nulll-pointer. Thanks for your contribution!
Sorry, but I fixed this bug in b2eaf6a before seeing #14139 or this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment