Display the secret for 2FA - #14128 #14154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ramantehlan <ramantehlan@gmail.com>
Signed-off-by: ramantehlan <ramantehlan@gmail.com>
ramantehlan
changed the title
MauricioFauth
requested changes
Apr 24, 2018
There was a problem hiding this comment.
Hi, @ramantehlan. Thanks for your contribution.
I just reviewed your pull request.
| @@ -6,5 +6,9 @@ | |||
| <img src="{{ image }}" /> | |||
| </p> | |||
| <p> | |||
| {% trans "Secret/key:" %} <b>{{ secret }}</b> | |||
There was a problem hiding this comment.
Could you replace the b tag with the strong tag?
| @@ -97,6 +97,7 @@ public function setup() | |||
| ); | |||
| return Template::get('login/twofactor/application_configure')->render([ | |||
| 'image' => $inlineUrl, | |||
| 'secret' => $_SESSION['2fa_application_key'] | |||
There was a problem hiding this comment.
Wouldn't it be better to use $this->_twofactor->config['settings']['secret'] here?
| {% trans "Secret/key:" %} <b>{{ secret }}</b> | ||
| </p> | ||
| <p> | ||
| <label>{% trans "Authentication code:" %} <input type="text" name="2fa_code" /></label> |
There was a problem hiding this comment.
This line is duplicate, could you remove it?
|
Merged, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this commit, users will be able to see secret/key for 2FA, in case they can't scan QR code. #14128