Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query builder doesn't work when selected column is * #14049 issue fix #14165

Closed
wants to merge 8 commits into from

Conversation

@aswaniprakash
Copy link
Contributor

@aswaniprakash aswaniprakash commented Apr 6, 2018

Signed-off-by: Aswani Prakash aswani15prakash@gmail.com

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
@phpmyadmin-bot

This comment has been minimized.

Copy link

@phpmyadmin-bot phpmyadmin-bot commented on b9fc484 Mar 12, 2018

This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check contributing documentation for more information.

Signed-off-by: aswani <aswani15prakash@gmail.com>
Signed-off-by: aswani <aswani15prakash@gmail.com>
@phpmyadmin-bot

This comment has been minimized.

Copy link

@phpmyadmin-bot phpmyadmin-bot commented on 90fbcc3 Mar 13, 2018

This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: js/db_multi_table_query.js

Signed-off-by: aswani <aswani15prakash@gmail.com>
Signed-off-by: aswani <aswani15prakash@gmail.com>
Signed-off-by: aswani <aswani15prakash@gmail.com>
Signed-off-by: Aswani Prakash <aswani15prakash@gmail.com>
@aswaniprakash aswaniprakash changed the title Pma 14049 Query builder doesn't work when selected column is * #14049 issue fix Apr 6, 2018
@mauriciofauth
Copy link
Member

@mauriciofauth mauriciofauth commented Apr 24, 2018

Closed in favor of #14228.

@mauriciofauth mauriciofauth self-assigned this Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants