Changes to make Get auto saved query and show this query here again button functional #14166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nctional Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
Piyush3079
force-pushed
the
autosave_sql_changes
branch
from
aabadda
to
6a44368
Compare
Codecov Report
@@ Coverage Diff @@
## master #14166 +/- ##
============================================
+ Coverage 52.89% 52.93% +0.04%
- Complexity 14332 14350 +18
============================================
Files 492 492
Lines 63665 63750 +85
============================================
+ Hits 33676 33748 +72
- Misses 29989 30002 +13 |
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
Piyush3079
force-pushed
the
autosave_sql_changes
branch
from
4ee2638
to
30cbbb8
Compare
Piyush3079
force-pushed
the
autosave_sql_changes
branch
2 times, most recently
from
adeb7ea
to
93286da
Compare
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
|
Merged, thanks for your contribution! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No auto saved query everytime new sql page is loaded: fixes #14093
Fix bugs in SQL query restore after session expire: closes #14094
SQL tab already has a query loaded: fixes #14118
"Show this query here again" checkbox does not work: fixes #14144
Not showing previous query on clearing Codemirror and then clicking get saved query: fixes #14148
Not showing default query on changing table: fixes #14163
Before submitting pull request, please check that every commit: