New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to make Get auto saved query and show this query here again button functional #14166

Merged
merged 6 commits into from May 3, 2018

Conversation

Projects
None yet
2 participants
@Piyush3079
Contributor

Piyush3079 commented Apr 6, 2018

No auto saved query everytime new sql page is loaded: fixes #14093
Fix bugs in SQL query restore after session expire: closes #14094
SQL tab already has a query loaded: fixes #14118
"Show this query here again" checkbox does not work: fixes #14144
Not showing previous query on clearing Codemirror and then clicking get saved query: fixes #14148
Not showing default query on changing table: fixes #14163
Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

Piyush3079 added some commits Apr 6, 2018

Handling of autosaved query and making get auto-saved query button fu…
…nctional

Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
Basic functionality of show this query here again added
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
Show this query here again checkbox working properly
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
deleting auto_saved_sql on clicking submit query button
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
@codecov

This comment has been minimized.

codecov bot commented Apr 7, 2018

Codecov Report

Merging #14166 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master   #14166      +/-   ##
============================================
+ Coverage     52.89%   52.93%   +0.04%     
- Complexity    14332    14350      +18     
============================================
  Files           492      492              
  Lines         63665    63750      +85     
============================================
+ Hits          33676    33748      +72     
- Misses        29989    30002      +13
javascript error handled
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
javascript error of JSON undefined removed
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

@mauriciofauth mauriciofauth merged commit 9c7c5ca into phpmyadmin:master May 3, 2018

2 of 4 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
DCO All commits have a DCO sign-off from the author
Details
Scrutinizer Analysis: 19 new issues, 4 updated code elements – Tests: passed
Details
@mauriciofauth

This comment has been minimized.

Member

mauriciofauth commented May 3, 2018

Merged, thanks for your contribution!

@mauriciofauth mauriciofauth self-assigned this May 3, 2018

@mauriciofauth mauriciofauth added this to the 5.0.0 milestone May 3, 2018

@mauriciofauth mauriciofauth referenced this pull request May 3, 2018

Closed

Fix bugs in SQL query restore after session expire #14094

4 of 4 tasks complete

@Piyush3079 Piyush3079 deleted the Piyush3079:autosave_sql_changes branch May 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment