New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Inline Styles from Routines.php #14179

Merged
merged 1 commit into from Apr 24, 2018

Conversation

Projects
None yet
2 participants
@rijaspk
Contributor

rijaspk commented Apr 10, 2018

Related to #12262
Signed-off-by: Rijas Ahammed PK rijaspk5195@gmail.com

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
@mauriciofauth

This comment has been minimized.

Member

mauriciofauth commented Apr 19, 2018

Hello. Thanks for your contribution!

Could you use your real name in the signature tag?
For example: Signed-off-by: Jane Developer <jane@example.org>

See Developer's Certificate of Origin

Remove Inline Styles from Ruotines.php
Signed-off-by: Rijas Ahammed PK <rijaspk5195@gmail.com>
@codecov

This comment has been minimized.

codecov bot commented Apr 19, 2018

Codecov Report

Merging #14179 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master   #14179      +/-   ##
============================================
- Coverage     52.89%   52.89%   -0.01%     
  Complexity    14351    14351              
============================================
  Files           492      492              
  Lines         63664    63663       -1     
============================================
- Hits          33675    33674       -1     
  Misses        29989    29989
@rijaspk

This comment has been minimized.

Contributor

rijaspk commented Apr 19, 2018

@mauriciofauth
Hi! Rijas is my real name. However, I have updated the signature with my full name as per your suggestion to avoid any confusion. Thanks!

@mauriciofauth mauriciofauth merged commit 374b237 into phpmyadmin:master Apr 24, 2018

5 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
codecov/patch 100% of diff hit (target 52.89%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +47.1% compared to ea5c066
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mauriciofauth

This comment has been minimized.

Member

mauriciofauth commented Apr 24, 2018

Merged, thanks for your contribution!

@mauriciofauth mauriciofauth self-assigned this Apr 24, 2018

@mauriciofauth mauriciofauth added this to the 5.0.0 milestone Apr 24, 2018

@rijaspk rijaspk changed the title from Remove Inline Styles from Ruotines.php to Remove Inline Styles from Routines.php Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment