Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove Inline Styles from Routines.php #14179
Conversation
This comment has been minimized.
This comment has been minimized.
|
Hello. Thanks for your contribution! Could you use your real name in the signature tag? |
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Apr 19, 2018
•
Codecov Report
@@ Coverage Diff @@
## master #14179 +/- ##
============================================
- Coverage 52.89% 52.89% -0.01%
Complexity 14351 14351
============================================
Files 492 492
Lines 63664 63663 -1
============================================
- Hits 33675 33674 -1
Misses 29989 29989 |
This comment has been minimized.
This comment has been minimized.
|
@mauriciofauth |
mauriciofauth
merged commit 374b237
into
phpmyadmin:master
Apr 24, 2018
5 checks passed
Codacy/PR Quality Review
Up to standards. A positive pull request.
Details
Scrutinizer
Analysis: No new issues – Tests: passed
Details
codecov/patch
100% of diff hit (target 52.89%)
Details
codecov/project
Absolute coverage decreased by -<.01% but relative coverage increased by +47.1% compared to ea5c066
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
|
Merged, thanks for your contribution! |
mauriciofauth
self-assigned this
Apr 24, 2018
mauriciofauth
added this to the 5.0.0 milestone
Apr 24, 2018
rijaspk
changed the title from
Remove Inline Styles from Ruotines.php
to
Remove Inline Styles from Routines.php
Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
rijaspk commentedApr 10, 2018
•
edited
Related to #12262
Signed-off-by: Rijas Ahammed PK rijaspk5195@gmail.com
Before submitting pull request, please check that every commit: