New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum version to PHP 7.1 #14186

Merged
merged 1 commit into from Apr 12, 2018

Conversation

Projects
None yet
1 participant
@mauriciofauth
Member

mauriciofauth commented Apr 11, 2018

Fix #13896

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

@mauriciofauth mauriciofauth added this to the 5.0.0 milestone Apr 11, 2018

@codecov

This comment has been minimized.

codecov bot commented Apr 11, 2018

Codecov Report

Merging #14186 into master will decrease coverage by 2.67%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master   #14186      +/-   ##
============================================
- Coverage     55.49%   52.82%   -2.68%     
  Complexity    14396    14396              
============================================
  Files           494      494              
  Lines         70695    63892    -6803     
============================================
- Hits          39233    33749    -5484     
+ Misses        31462    30143    -1319
Upgrade to PHP 7.1
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>

@mauriciofauth mauriciofauth merged commit f66f04a into phpmyadmin:master Apr 12, 2018

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Codacy/PR Quality Review Good work! A positive pull request.
Details
DCO All commits have a DCO sign-off from the author
Scrutinizer Analysis: No new issues – Tests: passed
Details

@mauriciofauth mauriciofauth deleted the mauriciofauth:php71 branch Apr 12, 2018

@mauriciofauth mauriciofauth self-assigned this Apr 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment