Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for ui regression issues #14196

Closed
wants to merge 1 commit into from
Closed

Conversation

@aroralakshya
Copy link
Contributor

@aroralakshya aroralakshya commented Apr 13, 2018

Fixes #14193, #14194
Implementation:
Add a horizontal scrollbar at the top of the table which is fixed at the top when the user scrolls down.

Signed-Off-By: Lakshya arora arora.lakshya123@gmail.com

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
@codecov
Copy link

@codecov codecov bot commented Apr 13, 2018

Codecov Report

Merging #14196 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #14196      +/-   ##
============================================
+ Coverage     52.89%   52.93%   +0.04%     
- Complexity    14332    14344      +12     
============================================
  Files           492      492              
  Lines         63665    63745      +80     
============================================
+ Hits          33676    33744      +68     
- Misses        29989    30001      +12
@aroralakshya
Copy link
Contributor Author

@aroralakshya aroralakshya commented Apr 13, 2018

How can i change the email address which DCO recognizes in sign off tag??

@ibennetch
Copy link
Member

@ibennetch ibennetch commented Apr 14, 2018

This is configured in your own Git instance; you could edit ~/.gitconfig or use git config: https://help.github.com/articles/setting-your-commit-email-address-in-git/

Fixes #14193, #14194
Implementation:
Add a horizontal scrollbar at the top of the table which is fixed at the top when  the user scrolls down.

Signed-Off-By: Lakshya arora <arora.lakshya123@gmail.com>
@mauriciofauth
Copy link
Member

@mauriciofauth mauriciofauth commented Apr 24, 2018

This works, but I don't know if it's the best solution.
I'm inclined to revert e92b357 and reopen #13959 until we have another solution.
What do you think about it?

@aroralakshya
Copy link
Contributor Author

@aroralakshya aroralakshya commented Apr 25, 2018

@mauriciofauth, I agree. It's clear that users appreciate the previous implementation. And I agree that it would be difficult for them to scroll horizontally using a small scrollbar at the middle of the page since most of us are used to using the bottom horizontal scrollbar. Moreover, it has some issued related like #14199, and maybe some more unforeseen ones.

@mauriciofauth mauriciofauth self-assigned this Apr 25, 2018
@bepsvpt bepsvpt mentioned this pull request Jun 19, 2018
2 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants