New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember table's sorting broken in 4.8.0 issue: #14189 fixed #14204

Merged
merged 2 commits into from May 12, 2018

Conversation

Projects
None yet
2 participants
@Piyush3079
Contributor

Piyush3079 commented Apr 16, 2018

Signed-off-by: Piyush Vijay piyushvijay.1997@gmail.com
Remember table's sorting broken in 4.8.0 #14189 issue fixed
Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
@codecov

This comment has been minimized.

codecov bot commented Apr 16, 2018

Codecov Report

Merging #14204 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #14204   +/-   ##
=========================================
  Coverage     52.89%   52.89%           
  Complexity    14338    14338           
=========================================
  Files           492      492           
  Lines         63665    63665           
=========================================
  Hits          33676    33676           
  Misses        29989    29989

Piyush3079 added some commits Apr 16, 2018

Remember table's sorting broken in 4.8.0 issue: #14189 fixed
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
javascript warnings of eslint removed
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
@mauriciofauth

This comment has been minimized.

Member

mauriciofauth commented May 4, 2018

@Piyush3079 I could not reproduce the issue.
How did you reproduce this?

@Piyush3079

This comment has been minimized.

Contributor

Piyush3079 commented May 8, 2018

@mauriciofauth Just login to PMA and go to Settings->Main Panel->Browse Mode and uncheck remember table sorting. Now go to any table and sort table by PRIMARY(ASEC) or PRIMARY(DESC). Now refresh the page. As you have unckecked the remember table sorting option, it should load the table data with sorting NONE but it is showing the data in sorted order as you have selected earlier.

@mauriciofauth mauriciofauth merged commit 1f76f85 into phpmyadmin:master May 12, 2018

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
DCO All commits have a DCO sign-off from the author
Details
Scrutinizer Analysis: 2 new issues, 2 updated code elements – Tests: passed
Details
@mauriciofauth

This comment has been minimized.

Member

mauriciofauth commented May 12, 2018

Merged, thanks for your contribution!

@mauriciofauth mauriciofauth self-assigned this May 12, 2018

@mauriciofauth mauriciofauth added this to the 4.8.1 milestone May 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment