New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Metro theme #14210

Merged
merged 1 commit into from Apr 29, 2018

Conversation

Projects
None yet
3 participants
@mauriciofauth
Member

mauriciofauth commented Apr 19, 2018

Fix #12373

See https://github.com/phpmyadmin/phpmyadmin/wiki/2017-04_Meeting

Signed-off-by: Maurício Meneghini Fauth mauriciofauth@gmail.com

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
@ibennetch

This comment has been minimized.

Member

ibennetch commented Apr 19, 2018

Related: #14175

Add Metro theme
Fix #12373

See https://github.com/phpmyadmin/phpmyadmin/wiki/2017-04_Meeting

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@phpmyadmin-bot

This comment has been minimized.

phpmyadmin-bot commented on 1c4868f Apr 19, 2018

This commit is using tab character for indentation instead of spaces, what is mandated by phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: themes/metro/jquery/jquery-ui.css

This comment has been minimized.

phpmyadmin-bot replied Apr 19, 2018

This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: themes/metro/css/jqplot.css.php

@codecov

This comment has been minimized.

codecov bot commented Apr 19, 2018

Codecov Report

Merging #14210 into master will decrease coverage by 2.64%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master   #14210      +/-   ##
============================================
- Coverage     52.89%   50.25%   -2.65%     
  Complexity    14351    14351              
============================================
  Files           492      502      +10     
  Lines         63664    67009    +3345     
============================================
  Hits          33675    33675              
- Misses        29989    33334    +3345

@mauriciofauth mauriciofauth self-assigned this Apr 29, 2018

@mauriciofauth mauriciofauth added this to the 5.0.0 milestone Apr 29, 2018

@mauriciofauth mauriciofauth merged commit 3c71a77 into phpmyadmin:master Apr 29, 2018

3 of 6 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
codecov/patch 0% of diff hit (target 52.89%)
Details
codecov/project 50.25% (-2.65%) compared to 8f32791
Details
DCO All commits have a DCO sign-off from the author
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mauriciofauth mauriciofauth deleted the mauriciofauth:themes branch Apr 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment