Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd Metro theme #14210
Conversation
This comment has been minimized.
This comment has been minimized.
|
Related: #14175 |
This comment has been minimized.
This comment has been minimized.
phpmyadmin-bot
commented on 1c4868f
Apr 19, 2018
|
This commit is using tab character for indentation instead of spaces, what is mandated by phpMyAdmin. Please check our Developer guidelines for more information. Offending files: themes/metro/jquery/jquery-ui.css |
This comment has been minimized.
This comment has been minimized.
phpmyadmin-bot
replied
Apr 19, 2018
|
This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our Developer guidelines for more information. Offending files: themes/metro/css/jqplot.css.php |
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Apr 19, 2018
•
Codecov Report
@@ Coverage Diff @@
## master #14210 +/- ##
============================================
- Coverage 52.89% 50.25% -2.65%
Complexity 14351 14351
============================================
Files 492 502 +10
Lines 63664 67009 +3345
============================================
Hits 33675 33675
- Misses 29989 33334 +3345 |
mauriciofauth
self-assigned this
Apr 29, 2018
mauriciofauth
added this to the 5.0.0 milestone
Apr 29, 2018
mauriciofauth
merged commit 3c71a77
into
phpmyadmin:master
Apr 29, 2018
3 of 6 checks passed
Codacy/PR Quality Review
Not up to standards. This pull request quality could be better.
Details
codecov/patch
0% of diff hit (target 52.89%)
Details
codecov/project
50.25% (-2.65%) compared to 8f32791
Details
DCO
All commits have a DCO sign-off from the author
Details
Scrutinizer
Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
mauriciofauth
deleted the
mauriciofauth:themes
branch
Apr 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
mauriciofauth commentedApr 19, 2018
Fix #12373
See https://github.com/phpmyadmin/phpmyadmin/wiki/2017-04_Meeting
Signed-off-by: Maurício Meneghini Fauth mauriciofauth@gmail.com
Before submitting pull request, please check that every commit: