/phpmyadmin

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate hidden token input field issue solved #14211

Merged
merged 2 commits into from May 4, 2018

Conversation

Reviewers
No reviews
Assignees

@mauriciofauth mauriciofauth

Labels
None yet
Projects
None yet
Milestone
  5.0.0
2 participants
@Piyush3079 @mauriciofauth
@Piyush3079
Contributor

Piyush3079 commented Apr 19, 2018 •
edited

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

Piyush3079 added some commits Apr 18, 2018

@Piyush3079
Duplicate hidden token input fields: #14209 issue fixed 
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
Verified
This commit was signed with a verified signature.
@Piyush3079 Piyush3079 Piyush Vijay
GPG key ID: FC77A75558658D35 Learn about signing commits
35ed77c
@Piyush3079
duplicate hidden input for token removed from error reporting form. 
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
Verified
This commit was signed with a verified signature.
@Piyush3079 Piyush3079 Piyush Vijay
GPG key ID: FC77A75558658D35 Learn about signing commits
Loading status checks…
06cf6e5
@codecov

This comment has been minimized.

Sign in to view

codecov bot commented Apr 19, 2018 •
edited

Codecov Report

Merging #14211 into master will not change coverage.
The diff coverage is 50%.

@@            Coverage Diff            @@
##             master   #14211   +/-   ##
=========================================
  Coverage     52.89%   52.89%           
  Complexity    14351    14351           
=========================================
  Files           492      492           
  Lines         63664    63664           
=========================================
  Hits          33675    33675           
  Misses        29989    29989

@mauriciofauth mauriciofauth merged commit 4304a66 into phpmyadmin:master May 4, 2018
4 of 6 checks passed

4 of 6 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
codecov/patch 50% of diff hit (target 52.89%)
Details
DCO All commits have a DCO sign-off from the author
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
codecov/project 52.89% remains the same compared to ea5c066
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mauriciofauth mauriciofauth self-assigned this May 4, 2018

@mauriciofauth mauriciofauth added this to the 5.0.0 milestone May 4, 2018

@mauriciofauth

This comment has been minimized.

Sign in to view
Member

mauriciofauth commented May 4, 2018

Merged, thanks for your contribution!

@Piyush3079 Piyush3079 deleted the Piyush3079:PMA_14209_ branch May 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment