Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XML Export fatal error and add Move columns preview SQL #14216

Merged
merged 2 commits into from May 4, 2018

Conversation

@Piyush3079
Copy link
Contributor

@Piyush3079 Piyush3079 commented Apr 20, 2018

Signed-off-by: Piyush Vijay piyushvijay.1997@gmail.com
XML Export from single table throws fatal error (PHP 7.2): Fixes #14212
Move columns preview SQL: Resolves #14155
Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
…ue fixed

Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
@codecov
Copy link

@codecov codecov bot commented Apr 20, 2018

Codecov Report

Merging #14216 into master will decrease coverage by <.01%.
The diff coverage is 9.09%.

@@             Coverage Diff              @@
##             master   #14216      +/-   ##
============================================
- Coverage     52.89%   52.89%   -0.01%     
- Complexity    14351    14354       +3     
============================================
  Files           492      492              
  Lines         63665    63672       +7     
============================================
+ Hits          33676    33677       +1     
- Misses        29989    29995       +6
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
@Piyush3079 Piyush3079 force-pushed the Piyush3079:PMA_14212 branch from 8dc8852 to efaf470 Apr 21, 2018
@mauriciofauth mauriciofauth changed the title XML Export from single table throws fatal error (PHP 7.2): #14212 issue fixed Fix XML Export fatal error and add Move columns preview SQL May 4, 2018
@mauriciofauth mauriciofauth self-assigned this May 4, 2018
@mauriciofauth mauriciofauth merged commit 2f824e5 into phpmyadmin:master May 4, 2018
4 of 6 checks passed
4 of 6 checks passed
codecov/patch 9.09% of diff hit (target 52.89%)
Details
codecov/project 52.89% (-0.01%) compared to 2efd1a3
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
DCO All commits have a DCO sign-off from the author
Details
Scrutinizer Analysis: 2 new issues, 1 updated code elements – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mauriciofauth
Copy link
Member

@mauriciofauth mauriciofauth commented May 4, 2018

@Piyush3079 Merged, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants