Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XML Export fatal error and add Move columns preview SQL #14216

Merged
merged 2 commits into from May 4, 2018

Conversation

Piyush3079
Copy link
Contributor

@Piyush3079 Piyush3079 commented Apr 20, 2018

Signed-off-by: Piyush Vijay piyushvijay.1997@gmail.com
XML Export from single table throws fatal error (PHP 7.2): Fixes #14212
Move columns preview SQL: Resolves #14155
Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

…#14212 issue fixed

Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
@codecov
Copy link

codecov bot commented Apr 20, 2018

Codecov Report

Merging #14216 into master will decrease coverage by <.01%.
The diff coverage is 9.09%.

@@             Coverage Diff              @@
##             master   #14216      +/-   ##
============================================
- Coverage     52.89%   52.89%   -0.01%     
- Complexity    14351    14354       +3     
============================================
  Files           492      492              
  Lines         63665    63672       +7     
============================================
+ Hits          33676    33677       +1     
- Misses        29989    29995       +6

Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
@MauricioFauth MauricioFauth changed the title XML Export from single table throws fatal error (PHP 7.2): #14212 issue fixed Fix XML Export fatal error and add Move columns preview SQL May 4, 2018
@MauricioFauth MauricioFauth self-assigned this May 4, 2018
@MauricioFauth MauricioFauth merged commit 2f824e5 into phpmyadmin:master May 4, 2018
@MauricioFauth
Copy link
Member

@Piyush3079 Merged, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[4.8.0] XML Export from single table throws fatal error (PHP 7.2) Feature Request: Move columns preview SQL
2 participants