New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use array_key_exists instead of in_array + array_keys #14224

Merged
merged 1 commit into from Apr 23, 2018

Conversation

Projects
None yet
2 participants
@carusogabriel
Contributor

carusogabriel commented Apr 23, 2018

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
Use array_key_exists instead of in_array + array_keys
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>

@mauriciofauth mauriciofauth merged commit 12247e9 into phpmyadmin:master Apr 23, 2018

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
DCO All commits have a DCO sign-off from the author
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
@mauriciofauth

This comment has been minimized.

Member

mauriciofauth commented Apr 23, 2018

Merged, thanks for your contribution!

@mauriciofauth mauriciofauth self-assigned this Apr 23, 2018

@mauriciofauth mauriciofauth added this to the 5.0.0 milestone Apr 23, 2018

@carusogabriel carusogabriel deleted the carusogabriel:array-key-exists branch Apr 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment