New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#14049 issue fix Query builder doesn't work when the selected column … #14228

Merged
merged 1 commit into from Apr 24, 2018

Conversation

Projects
None yet
2 participants
@aswaniprakash
Contributor

aswaniprakash commented Apr 24, 2018

…is *

Signed-off-by: Aswani Prakash aswani15prakash@gmail.com

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
#14049 issue fix Query builder doesn't work when the selected column …
…is *

Signed-off-by: Aswani Prakash <aswani15prakash@gmail.com>
@codecov

This comment has been minimized.

codecov bot commented Apr 24, 2018

Codecov Report

Merging #14228 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #14228   +/-   ##
=========================================
  Coverage     52.89%   52.89%           
  Complexity    14351    14351           
=========================================
  Files           492      492           
  Lines         63664    63664           
=========================================
  Hits          33675    33675           
  Misses        29989    29989

@mauriciofauth mauriciofauth merged commit 15a3488 into phpmyadmin:master Apr 24, 2018

5 of 6 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
DCO All commits have a DCO sign-off from the author
Details
Scrutinizer Analysis: 7 new issues, 1 updated code elements – Tests: passed
Details
codecov/patch Coverage not affected when comparing 374b237...5f3f484
Details
codecov/project 52.89% remains the same compared to 374b237
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mauriciofauth

This comment has been minimized.

Member

mauriciofauth commented Apr 24, 2018

Merged, thanks for your contribution!

@mauriciofauth mauriciofauth self-assigned this Apr 24, 2018

@mauriciofauth mauriciofauth added this to the 4.8.1 milestone Apr 24, 2018

@aswaniprakash aswaniprakash deleted the aswaniprakash:PMA_iss14049 branch Apr 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment