Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#13893 issue fix Simulating queries produce unexpected results #14231

Merged
merged 1 commit into from May 16, 2018

Conversation

@aswaniprakash
Copy link
Contributor

@aswaniprakash aswaniprakash commented Apr 25, 2018

Fix #13893

Signed-off-by: Aswani Prakash aswani15prakash@gmail.com

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
Signed-off-by: Aswani Prakash <aswani15prakash@gmail.com>
Copy link
Contributor

@saulotoledo saulotoledo left a comment

Minor suggestions.

@@ -1460,7 +1460,11 @@ public function getSimulatedUpdateQuery(array $analyzed_sql_results)
$diff = array();
foreach ($analyzed_sql_results['statement']->set as $set) {
$columns[] = $set->column;
$diff[] = $set->column . ' <> ' . $set->value;
$not_equal_operator = ' <> ';
if(strtoupper($set->value) == 'NULL'){

This comment has been minimized.

@saulotoledo

saulotoledo May 6, 2018
Contributor

I suggest to fix the format: if ( and ) { (note the missing spaces).

And how about using ===?

@mauriciofauth mauriciofauth merged commit 594cb7b into phpmyadmin:master May 16, 2018
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
DCO All commits have a DCO sign-off from the author
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
@mauriciofauth mauriciofauth self-assigned this May 16, 2018
@mauriciofauth mauriciofauth added this to the 4.8.1 milestone May 16, 2018
@mauriciofauth
Copy link
Member

@mauriciofauth mauriciofauth commented May 16, 2018

Merged, thanks for your contribution!

@aswaniprakash aswaniprakash deleted the aswaniprakash:PMA_13893 branch May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants