Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#14253 Git commit info not showing when the repository is a submodule #14254

Merged

Conversation

@williamdes
Copy link
Member

@williamdes williamdes commented May 3, 2018

Closes: #14253
I added tests for Config::checkGitRevision and Config::isGitRevision

… submodule

Added tests for Config::checkGitRevision and Config::isGitRevision

Closes: phpmyadmin#14253
Signed-off-by: William Desportes <williamdes@wdes.fr>
@codecov
Copy link

@codecov codecov bot commented May 3, 2018

Codecov Report

Merging #14254 into master will increase coverage by 0.15%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master   #14254      +/-   ##
============================================
+ Coverage      50.3%   50.45%   +0.15%     
- Complexity    14373    14376       +3     
============================================
  Files           502      502              
  Lines         67020    67036      +16     
============================================
+ Hits          33714    33825     +111     
+ Misses        33306    33211      -95

Loading

@mauriciofauth mauriciofauth merged commit 475c186 into phpmyadmin:master May 4, 2018
5 of 6 checks passed
Loading
@mauriciofauth mauriciofauth self-assigned this May 4, 2018
@mauriciofauth mauriciofauth added this to the 5.0.0 milestone May 4, 2018
@mauriciofauth
Copy link
Member

@mauriciofauth mauriciofauth commented May 4, 2018

Merged, thanks for your contribution!

Loading

@williamdes williamdes deleted the issue-14253-git-submodule branch May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants