Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#14253 Git commit info not showing when the repository is a submodule #14254

Merged
merged 1 commit into from May 4, 2018

Conversation

Projects
None yet
2 participants
@williamdes
Copy link
Member

williamdes commented May 3, 2018

Closes: #14253
I added tests for Config::checkGitRevision and Config::isGitRevision

#14253 Git commit info not showing when the repository is a submodule
Added tests for Config::checkGitRevision and Config::isGitRevision

Closes: #14253
Signed-off-by: William Desportes <williamdes@wdes.fr>
@codecov

This comment has been minimized.

Copy link

codecov bot commented May 3, 2018

Codecov Report

Merging #14254 into master will increase coverage by 0.15%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master   #14254      +/-   ##
============================================
+ Coverage      50.3%   50.45%   +0.15%     
- Complexity    14373    14376       +3     
============================================
  Files           502      502              
  Lines         67020    67036      +16     
============================================
+ Hits          33714    33825     +111     
+ Misses        33306    33211      -95

@mauriciofauth mauriciofauth merged commit 475c186 into phpmyadmin:master May 4, 2018

5 of 6 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
DCO All commits have a DCO sign-off from the author
Details
Scrutinizer Analysis: 7 updated code elements – Tests: passed
Details
codecov/patch 100% of diff hit (target 50.3%)
Details
codecov/project 50.45% (+0.15%) compared to c580f7e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mauriciofauth mauriciofauth self-assigned this May 4, 2018

@mauriciofauth mauriciofauth added this to the 5.0.0 milestone May 4, 2018

@mauriciofauth

This comment has been minimized.

Copy link
Member

mauriciofauth commented May 4, 2018

Merged, thanks for your contribution!

@williamdes williamdes deleted the williamdes:issue-14253-git-submodule branch May 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.