Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addapt getTableHeader to twig template #14255

merged 1 commit into from May 4, 2018


Copy link

@laps15 laps15 commented May 4, 2018

Signed-off-by: Leonardo Strozzi

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
Signed-off-by: Leonardo Strozzi <>
Copy link

@codecov codecov bot commented May 4, 2018

Codecov Report

Merging #14255 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master   #14255      +/-   ##
- Coverage     50.45%   50.44%   -0.02%     
+ Complexity    14376    14375       -1     
  Files           502      502              
  Lines         67036    67012      -24     
- Hits          33825    33801      -24     
  Misses        33211    33211
@mauriciofauth mauriciofauth merged commit dcb2aec into phpmyadmin:master May 4, 2018
5 of 6 checks passed
5 of 6 checks passed
Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
DCO All commits have a DCO sign-off from the author
Scrutinizer Analysis: 1 updated code elements – Tests: passed
codecov/patch 100% of diff hit (target 50.45%)
codecov/project Absolute coverage decreased by -0.01% but relative coverage increased by +49.54% compared to 4304a66
continuous-integration/travis-ci/pr The Travis CI build passed
@mauriciofauth mauriciofauth self-assigned this May 4, 2018
@mauriciofauth mauriciofauth added this to the 5.0.0 milestone May 4, 2018
Copy link

@mauriciofauth mauriciofauth commented May 4, 2018

Merged, thanks for your contribution!

@laps15 laps15 deleted the laps15:templates branch May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants