#14260 Fixed configuration for DefaultLang and Lang

[williamdes]

$GLOBALS['cfg'] is not set before :

phpmyadmin/libraries/common.inc.php

Line 287 in bb9fc5d

$GLOBALS['PMA_Config']->enableBc();

So $GLOBALS['cfg'] cannot be used in

phpmyadmin/libraries/common.inc.php

Line 255 in bb9fc5d

$language = LanguageManager::getInstance()->selectLanguage();

phpmyadmin/libraries/classes/LanguageManager.php

Lines 822 to 831 in bb9fc5d

	public function selectLanguage()
	{
	// check forced language
	if (! empty($GLOBALS['cfg']['Lang'])) {
	$lang = $this->getLanguage($GLOBALS['cfg']['Lang']);
	if ($lang !== false) {
	return $lang;
	}
	$this->_lang_failed_cfg = true;
	}

And

phpmyadmin/libraries/classes/LanguageManager.php

Lines 886 to 892 in bb9fc5d

	if (isset($langs[$GLOBALS['cfg']['DefaultLang']])) {
	return $langs[$GLOBALS['cfg']['DefaultLang']];
	}
	// Fallback to English
	return $langs['en'];
	}

Solution

Migrate to $GLOBALS['PMA_Config']->get('nameofkey') instead of $GLOBALS['cfg']['nameofkey']

More info

Unit tests never failed because the globals where setup for the test.
I updated the test and added a test case that was not covered (cookie test case)

Closes: #14260

[williamdes]

@MauricioFauth CodeCov seems broken ...
https://codecov.io/gh/phpmyadmin/phpmyadmin/commit/2f84b4034e4c423512029534e7a6132e6f8dc4d3

Should we add php-recode extension ?
PhpMyAdmin\Tests\EncodingTest::testRecode
recode extension missing

[MauricioFauth]

Merged, thanks for your contribution!

[MauricioFauth]

The test should not fail if the recode extension is missing.
Apparently it was a network error.
WARNING Unable to get report from archive, will try again.
ERROR Max retries exceeded