Skip to content

/ phpmyadmin

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #14019 fix: Allow parameter in AllowThirdPartyFraming #14265

Merged
merged 1 commit into from May 13, 2018
Merged

Issue #14019 fix: Allow parameter in AllowThirdPartyFraming #14265

merged 1 commit into from May 13, 2018

Conversation

@aswaniprakash
Copy link
Contributor

@aswaniprakash aswaniprakash commented May 8, 2018 •
edited by mauriciofauth

Fixes #14019

Signed-off-by: Aswani Prakash aswani15prakash@gmail.com

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
@aswaniprakash
Issue 14019 fix: Allow parameter in AllowThirdPartyFraming
Loading status checks…
6d3d6af 
Signed-off-by: Aswani Prakash <aswani15prakash@gmail.com>
@aswaniprakash aswaniprakash changed the title Issue 14019 fix: Allow parameter in AllowThirdPartyFraming Issue #14019 fix: Allow parameter in AllowThirdPartyFraming May 8, 2018
@phpmyadmin-bot

This comment has been minimized.

Sign in to view
Copy link

@phpmyadmin-bot phpmyadmin-bot commented on 6d3d6af May 8, 2018

This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: doc/config.rst, libraries/config.default.php

This comment has been minimized.

Sign in to view
Copy link

@phpmyadmin-bot phpmyadmin-bot replied May 8, 2018

This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: doc/config.rst, libraries/config.default.php

This comment has been minimized.

Sign in to view
Copy link

@phpmyadmin-bot phpmyadmin-bot replied May 8, 2018

This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: doc/config.rst, libraries/config.default.php

This comment has been minimized.

Sign in to view
Copy link

@phpmyadmin-bot phpmyadmin-bot replied May 8, 2018

This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: doc/config.rst, libraries/config.default.php
@mauriciofauth mauriciofauth merged commit e524d63 into phpmyadmin:master May 13, 2018
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
DCO All commits have a DCO sign-off from the author
Details
Scrutinizer Analysis: 1 updated code elements – Tests: passed
Details
@mauriciofauth
Copy link
Member

@mauriciofauth mauriciofauth commented May 13, 2018

Merged, thanks for your contribution!
@mauriciofauth mauriciofauth self-assigned this May 13, 2018
@mauriciofauth mauriciofauth added this to the 5.0.0 milestone May 13, 2018
@aswaniprakash aswaniprakash deleted the aswaniprakash:PMA_14019 branch May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mauriciofauth mauriciofauth

Labels
None yet
Projects
None yet
Milestone
5.0.0
Linked issues

Successfully merging this pull request may close these issues.

Allow parameter in 'AllowThirdPartyFraming'
3 participants
@aswaniprakash @mauriciofauth @phpmyadmin-bot