Require a polyfill instead of the cytpe extension #14267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ctype is an indirect dependency due to twig, and it isn't resolved there until a later version than we require. By requiring the symfony polyfill for cytpe everything will still run, regardless of the ctype availability. Twig will require this polyfill itself in a later version, but this makes sure we still allow earlier versions of twig to be used. Signed-off-by: Gert de Pagter <BackEndTea@gmail.com>
|
Merged, thanks for your contribution! |
|
Thank you @MauricioFauth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Before submitting pull request, please check that every commit:
Ctype is an indirect dependency due to twig, and it isn't resolved there until a later version than we require.
By requiring the symfony polyfill for cytpe everything will still run, regardless of the ctype availability.
Twig will require this polyfill itself in a later version, but this makes sure we still allow earlier versions of twig to be used.
Signed-off-by: Gert de Pagter BackEndTea@gmail.com