New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt html functions to Twig templates #14280

Merged
merged 2 commits into from May 10, 2018

Conversation

Projects
None yet
2 participants
@laps15
Contributor

laps15 commented May 10, 2018

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

laps15 added some commits May 10, 2018

Replace Util::getIcon by Twig exetension
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
Addapt getHtmlForTableRow to twig template
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>

@mauriciofauth mauriciofauth merged commit d56d6af into phpmyadmin:master May 10, 2018

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
DCO All commits have a DCO sign-off from the author
Details
Scrutinizer Analysis: 1 updated code elements – Tests: passed
Details

@mauriciofauth mauriciofauth self-assigned this May 10, 2018

@mauriciofauth mauriciofauth added this to the 5.0.0 milestone May 10, 2018

@mauriciofauth

This comment has been minimized.

Member

mauriciofauth commented May 10, 2018

Merged, thanks for your contribution!

@laps15 laps15 deleted the laps15:templates branch May 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment