Skip to content

Enable strict mode in some classes #14290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 15, 2018
Merged

Enable strict mode in some classes #14290

merged 5 commits into from
May 15, 2018

Conversation

MauricioFauth
Copy link
Member

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

@codecov
Copy link

codecov bot commented May 15, 2018 •
edited
Loading

Codecov Report

Merging #14290 into master will increase coverage by <.01%.
The diff coverage is 87.35%.

@@             Coverage Diff              @@
##             master   #14290      +/-   ##
============================================
+ Coverage     50.45%   50.45%   +<.01%     
- Complexity    14405    14406       +1     
============================================
  Files           502      502              
  Lines         67010    67013       +3     
============================================
+ Hits          33807    33811       +4     
+ Misses        33203    33202       -1

@MauricioFauth
Enable strict mode in some classes
6cf8ee0 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@MauricioFauth
Enable strict mode in Config classes
b6435e9 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@MauricioFauth
Enable strict mode in Controllers classes
5f46a4b 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@MauricioFauth
Enable strict mode in Database classes
764f7a7 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@MauricioFauth
Enable strict mode in Dbi classes
aa8ab16 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@MauricioFauth MauricioFauth merged commit c8bfcb7 into phpmyadmin:master May 15, 2018
@MauricioFauth MauricioFauth deleted the strict-types branch May 15, 2018 06:31
@MauricioFauth MauricioFauth self-assigned this May 15, 2018
@MauricioFauth MauricioFauth added this to the 5.0.0 milestone May 15, 2018
@MauricioFauth MauricioFauth mentioned this pull request May 16, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MauricioFauth MauricioFauth

Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@MauricioFauth