Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable strict mode in some classes #14290

Merged
merged 5 commits into from May 15, 2018

Conversation

@mauriciofauth
Copy link
Member

@mauriciofauth mauriciofauth commented May 15, 2018

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
@codecov
Copy link

@codecov codecov bot commented May 15, 2018

Codecov Report

Merging #14290 into master will increase coverage by <.01%.
The diff coverage is 87.35%.

@@             Coverage Diff              @@
##             master   #14290      +/-   ##
============================================
+ Coverage     50.45%   50.45%   +<.01%     
- Complexity    14405    14406       +1     
============================================
  Files           502      502              
  Lines         67010    67013       +3     
============================================
+ Hits          33807    33811       +4     
+ Misses        33203    33202       -1
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@mauriciofauth mauriciofauth force-pushed the mauriciofauth:strict-types branch from 5676431 to 764f7a7 May 15, 2018
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@mauriciofauth mauriciofauth merged commit c8bfcb7 into phpmyadmin:master May 15, 2018
5 checks passed
5 checks passed
DCO All commits have a DCO sign-off from the author
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
codecov/patch 87.35% of diff hit (target 50.45%)
Details
codecov/project 50.45% (+<.01%) compared to 15f6d8b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mauriciofauth mauriciofauth deleted the mauriciofauth:strict-types branch May 15, 2018
@mauriciofauth mauriciofauth self-assigned this May 15, 2018
@mauriciofauth mauriciofauth added this to the 5.0.0 milestone May 15, 2018
@mauriciofauth mauriciofauth mentioned this pull request May 16, 2018
4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant