Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated Theme generator #14293

Merged
merged 59 commits into from Jan 29, 2019

Conversation

@shucon
Copy link
Contributor

shucon commented May 15, 2018

For easy access to my work progress and any suggestions.
All of the work regarding GSoC has been included in this PR.

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

shucon added some commits May 15, 2018

Initial Commit
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Remove unwanted file
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Convert Tabs to Spaces
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Add new line
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
@@ -0,0 +1,2080 @@
var UIColorPicker = (function UIColorPicker() {

This comment has been minimized.

@Piyush3079

Piyush3079 May 15, 2018

Contributor

Is this a library of javascript?

This comment has been minimized.

@shucon

shucon May 16, 2018

Author Contributor

yes

This comment has been minimized.

@mauriciofauth

mauriciofauth Jun 3, 2018

Member

Did you write this library or is it a third-party library?

shucon added some commits May 16, 2018

Fixed Broken Tests and Removed unnecessary tools
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
@codecov

This comment has been minimized.

Copy link

codecov bot commented May 16, 2018

Codecov Report

Merging #14293 into master will increase coverage by 1.25%.
The diff coverage is 89.88%.

@@             Coverage Diff              @@
##             master   #14293      +/-   ##
============================================
+ Coverage     50.92%   52.17%   +1.25%     
+ Complexity    14021    13893     -128     
============================================
  Files           473      504      +31     
  Lines         65300    70372    +5072     
============================================
+ Hits          33254    36718    +3464     
- Misses        32046    33654    +1608
$scripts = $header->getScripts();
$scripts->addFile('theme_generator/color_picker.js');
$response->addHTML('<div id="container">');

This comment has been minimized.

@devenbansod

devenbansod May 16, 2018

Member

/suggestion You might want to add make a static variable for holding all the html and then use addHTML only once? (or consider using a twig template maybe, I know there is no dynamic data but maybe cleaner). I'd prefer the first one.

Let me know what you think.

This comment has been minimized.

@shucon

shucon May 16, 2018

Author Contributor

I may go with creating a twig template, as I'll be making preview panels later.

This comment has been minimized.

@shucon

shucon May 16, 2018

Author Contributor

I have created a mockup for the same https://researchweb.iiit.ac.in/~saksham.gupta/mockup2.jpg

shucon added some commits May 17, 2018

Remove Whitespace
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Brightness and Saturation variable Monochrome
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Trailing whitespace
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Adjacent Colour Palatte
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Whitespaces
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Weekly Progress - Completed 4 Automated Palletes
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Improve Code Quality
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Individual color changes
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Fix Bugs
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Improve Lint
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Fix Lint
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Fix all Lint errors
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Form addition
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
layout file creation
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Create Navigation file
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Fix whitespace
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
@@ -0,0 +1,1942 @@
/* vim: set expandtab sw=4 ts=4 sts=4: */
/**
* Library for the Color Picker Tool

This comment has been minimized.

@mauriciofauth

mauriciofauth Jun 3, 2018

Member

Did you write this library or is it a third-party library?

This comment has been minimized.

@shucon

shucon Jun 4, 2018

Author Contributor

Part of it is written and edited by me and part of it is a third-party library from https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Colors/Color_picker_tool

This comment has been minimized.

@mauriciofauth

mauriciofauth Jun 5, 2018

Member

I was only concerned with the license to use the code, but it seems that this code is under public domain, so no problems.

@mauriciofauth
Copy link
Member

mauriciofauth left a comment

I think we should have a setting to enable/disable the Theme Generator. What do you think, @ibennetch?

@williamdes

This comment has been minimized.

Copy link
Member

williamdes commented Oct 4, 2018

Related to: #6356

@stale

This comment has been minimized.

Copy link

stale bot commented Dec 4, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 4, 2018

@phpmyadmin-bot

This comment has been minimized.

Copy link

phpmyadmin-bot commented Dec 4, 2018

This pull requests contains too many commits, in most cases it is caused by wrong merge target. In case you have forked master branch you should also ask merging to master branch. See GitHub documentation for more details.

@stale stale bot removed the wontfix label Dec 4, 2018

@phpmyadmin-bot

This comment has been minimized.

Copy link

phpmyadmin-bot commented Dec 4, 2018

This pull requests contains too many commits, in most cases it is caused by wrong merge target. In case you have forked master branch you should also ask merging to master branch. See GitHub documentation for more details.

@shucon

This comment has been minimized.

Copy link
Contributor Author

shucon commented Dec 4, 2018

Commenting as the PR went stale. @ibennetch @mauriciofauth

@mauriciofauth

This comment has been minimized.

Copy link
Member

mauriciofauth commented Dec 4, 2018

As I commented before, I think we should have a setting to enable/disable the Theme Generator, because some people will not want to have this feature enabled.

@shucon

This comment has been minimized.

Copy link
Contributor Author

shucon commented Dec 5, 2018

@mauriciofauth where do you think it would be best to add this feature?

@ibennetch

This comment has been minimized.

Copy link
Member

ibennetch commented Dec 5, 2018

Theme Generator configuration option
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
@shucon

This comment has been minimized.

Copy link
Contributor Author

shucon commented Dec 7, 2018

@ibennetch @mauriciofauth can you have a look at it now?
Also, there are some errors in Travis, it's something new to me.
Can you please help me how to fix it.

@phpmyadmin phpmyadmin deleted a comment from phpmyadmin-bot Dec 7, 2018

@mauriciofauth

This comment has been minimized.

Copy link
Member

mauriciofauth commented Dec 7, 2018

@shucon PHPStan found 15 errors in your code.
See: https://travis-ci.org/phpmyadmin/phpmyadmin/jobs/464923677#L639

You can run PHPStan with: composer phpstan

shucon added some commits Dec 11, 2018

Fix phpstan errors
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
@phpmyadmin-bot

This comment has been minimized.

Copy link

phpmyadmin-bot commented Dec 11, 2018

This pull requests contains too many commits, in most cases it is caused by wrong merge target. In case you have forked master branch you should also ask merging to master branch. See GitHub documentation for more details.

@shucon

This comment has been minimized.

Copy link
Contributor Author

shucon commented Dec 11, 2018

@ibennetch @mauriciofauth @williamdes I think the PR is ready now.

@mauriciofauth mauriciofauth changed the base branch from master to gsoc-theme-generator Jan 29, 2019

@phpmyadmin-bot

This comment has been minimized.

Copy link

phpmyadmin-bot commented Jan 29, 2019

This pull requests contains too many commits, in most cases it is caused by wrong merge target. In case you have forked master branch you should also ask merging to master branch. See GitHub documentation for more details.

@mauriciofauth mauriciofauth merged commit 27b8fbe into phpmyadmin:gsoc-theme-generator Jan 29, 2019

1 of 4 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
codeclimate 76 issues to fix
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Scrutinizer Analysis: 171 new issues, 24 updated code elements – Tests: passed
Details
@phpmyadmin-bot

This comment has been minimized.

Copy link

phpmyadmin-bot commented Jan 29, 2019

This pull requests contains too many commits, in most cases it is caused by wrong merge target. In case you have forked master branch you should also ask merging to master branch. See GitHub documentation for more details.

2 similar comments
@phpmyadmin-bot

This comment has been minimized.

Copy link

phpmyadmin-bot commented Jan 29, 2019

This pull requests contains too many commits, in most cases it is caused by wrong merge target. In case you have forked master branch you should also ask merging to master branch. See GitHub documentation for more details.

@phpmyadmin-bot

This comment has been minimized.

Copy link

phpmyadmin-bot commented Jan 29, 2019

This pull requests contains too many commits, in most cases it is caused by wrong merge target. In case you have forked master branch you should also ask merging to master branch. See GitHub documentation for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.