Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upEnable strict mode in PHP files #14296
Conversation
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
May 16, 2018
•
Codecov Report
@@ Coverage Diff @@
## master #14296 +/- ##
============================================
+ Coverage 50.45% 50.45% +<.01%
Complexity 14406 14406
============================================
Files 502 502
Lines 67013 67013
============================================
+ Hits 33811 33812 +1
+ Misses 33202 33201 -1 |
mauriciofauth
added some commits
May 15, 2018
mauriciofauth
changed the title from
Enable strict mode in some classes
to
Enable strict mode in PHP files
May 16, 2018
mauriciofauth
added some commits
May 16, 2018
mauriciofauth
merged commit c1a54f7
into
phpmyadmin:master
May 16, 2018
6 checks passed
Codacy/PR Quality Review
Up to standards. A positive pull request.
Details
DCO
All commits have a DCO sign-off from the author
Details
Scrutinizer
Analysis: 2515 Issues, 60 Patches – Tests: passed
Details
codecov/patch
81.35% of diff hit (target 50.45%)
Details
codecov/project
50.45% (+<.01%) compared to db708a4
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
mauriciofauth
deleted the
mauriciofauth:strict-types
branch
May 16, 2018
mauriciofauth
self-assigned this
May 16, 2018
mauriciofauth
added this to the 5.0.0 milestone
May 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
mauriciofauth commentedMay 16, 2018
•
edited
Related to #14290
Before submitting pull request, please check that every commit: