Skip to content

/ phpmyadmin

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable strict mode in PHP files #14296

Merged
merged 15 commits into from May 16, 2018
Merged

Enable strict mode in PHP files #14296

merged 15 commits into from May 16, 2018

Conversation

@mauriciofauth
Copy link
Member

@mauriciofauth mauriciofauth commented May 16, 2018 •
edited

Related to #14290

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
@codecov
Copy link

@codecov codecov bot commented May 16, 2018 •
edited

Codecov Report

Merging #14296 into master will increase coverage by <.01%.
The diff coverage is 81.35%.

@@             Coverage Diff              @@
##             master   #14296      +/-   ##
============================================
+ Coverage     50.45%   50.45%   +<.01%     
  Complexity    14406    14406              
============================================
  Files           502      502              
  Lines         67013    67013              
============================================
+ Hits          33811    33812       +1     
+ Misses        33202    33201       -1
@mauriciofauth
Add ChangeLog entry for #14296
d8c16bc 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@mauriciofauth
Enable strict mode in Di classes
f3fcbdf 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@mauriciofauth
Enable strict mode in Display classes
267aadd 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@mauriciofauth
Enable strict mode in Engines classes
2be3ac8 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@mauriciofauth
Enable strict mode in Gis classes
107e0b1 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@mauriciofauth
Enable strict mode in Navigation classes
9dbae0a 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@mauriciofauth
Enable strict mode in Plugins classes
0998a50 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@mauriciofauth
Enable strict mode in Properties classes
cf44cc9 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@mauriciofauth mauriciofauth force-pushed the mauriciofauth:strict-types branch from 54217d4 to ed4a0a5 May 16, 2018
@mauriciofauth mauriciofauth changed the title Enable strict mode in some classes Enable strict mode in PHP files May 16, 2018
@mauriciofauth mauriciofauth force-pushed the mauriciofauth:strict-types branch from ed4a0a5 to d063e54 May 16, 2018
@mauriciofauth
Enable strict mode in Rte classes
56ce176 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@mauriciofauth
Enable strict mode in Server classes
c426891 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@mauriciofauth
Enable strict mode in Twig classes
0a53065 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@mauriciofauth
Enable strict mode in Utils/HttpRequest class
ec52933 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@mauriciofauth
Enable strict mode in libraries files
d243f7c 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@mauriciofauth mauriciofauth force-pushed the mauriciofauth:strict-types branch from d063e54 to bd6d03a May 16, 2018
@mauriciofauth
Enable strict mode in PHP files
af148ad 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@mauriciofauth
Enable strict mode in test files
Loading status checks…
dc8c92b 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@mauriciofauth mauriciofauth force-pushed the mauriciofauth:strict-types branch from bd6d03a to dc8c92b May 16, 2018
@mauriciofauth mauriciofauth merged commit c1a54f7 into phpmyadmin:master May 16, 2018
6 checks passed
6 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
DCO All commits have a DCO sign-off from the author
Details
Scrutinizer Analysis: 2515 Issues, 60 Patches – Tests: passed
Details
codecov/patch 81.35% of diff hit (target 50.45%)
Details
codecov/project 50.45% (+<.01%) compared to db708a4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mauriciofauth mauriciofauth deleted the mauriciofauth:strict-types branch May 16, 2018
@mauriciofauth mauriciofauth self-assigned this May 16, 2018
@mauriciofauth mauriciofauth added this to the 5.0.0 milestone May 16, 2018
@williamdes williamdes mentioned this pull request Jan 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mauriciofauth mauriciofauth

Labels
None yet
Projects
None yet
Milestone
5.0.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@mauriciofauth
You can’t perform that action at this time.