New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable strict mode in PHP files #14296

Merged
merged 15 commits into from May 16, 2018

Conversation

Projects
None yet
1 participant
@mauriciofauth
Member

mauriciofauth commented May 16, 2018

Related to #14290

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
@codecov

This comment has been minimized.

codecov bot commented May 16, 2018

Codecov Report

Merging #14296 into master will increase coverage by <.01%.
The diff coverage is 81.35%.

@@             Coverage Diff              @@
##             master   #14296      +/-   ##
============================================
+ Coverage     50.45%   50.45%   +<.01%     
  Complexity    14406    14406              
============================================
  Files           502      502              
  Lines         67013    67013              
============================================
+ Hits          33811    33812       +1     
+ Misses        33202    33201       -1

mauriciofauth added some commits May 15, 2018

Enable strict mode in Di classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Enable strict mode in Display classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Enable strict mode in Engines classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Enable strict mode in Gis classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Enable strict mode in Navigation classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Enable strict mode in Plugins classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Enable strict mode in Properties classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Add ChangeLog entry for #14296
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>

@mauriciofauth mauriciofauth changed the title from Enable strict mode in some classes to Enable strict mode in PHP files May 16, 2018

mauriciofauth added some commits May 16, 2018

Enable strict mode in Rte classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Enable strict mode in Server classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Enable strict mode in Twig classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Enable strict mode in Utils/HttpRequest class
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Enable strict mode in libraries files
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Enable strict mode in PHP files
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Enable strict mode in test files
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>

@mauriciofauth mauriciofauth merged commit c1a54f7 into phpmyadmin:master May 16, 2018

6 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
DCO All commits have a DCO sign-off from the author
Details
Scrutinizer Analysis: 2515 Issues, 60 Patches – Tests: passed
Details
codecov/patch 81.35% of diff hit (target 50.45%)
Details
codecov/project 50.45% (+<.01%) compared to db708a4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mauriciofauth mauriciofauth deleted the mauriciofauth:strict-types branch May 16, 2018

@mauriciofauth mauriciofauth self-assigned this May 16, 2018

@mauriciofauth mauriciofauth added this to the 5.0.0 milestone May 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment