Remove md5 twig extension #14305
Remove md5 twig extension #14305
Conversation
| @@ -1,5 +1,6 @@ | |||
| <tr> | |||
| <td class="vmiddle"> | |||
| <h1>{{ myfield_md5 }}</h1> | |||
There was a problem hiding this comment.
Is this addition intentional?
There was a problem hiding this comment.
Totally unintentional, I was using for debug only.
| @@ -654,6 +654,8 @@ protected function displayTableList() | |||
| Template::get('database/structure/structure_table_row') | |||
| ->render( | |||
| array( | |||
| 'table_name_hash' => md5($current_table['TABLE_NAME']), | |||
| 'db_table_name_hash' => md5($this->db.$current_table['TABLE_NAME']), | |||
There was a problem hiding this comment.
Could you add one space before and after the concat operator?
There was a problem hiding this comment.
Done! There was a '.' missing between the db name ante the table name, fixed that too.
Codecov Report
@@ Coverage Diff @@
## master #14305 +/- ##
============================================
- Coverage 50.45% 50.44% -0.01%
- Complexity 14410 14411 +1
============================================
Files 502 502
Lines 67019 67025 +6
============================================
- Hits 33814 33813 -1
- Misses 33205 33212 +7 |
| @@ -117,7 +117,7 @@ | |||
| {% set myfield = save_row[i]['Field'] %} | |||
| {# Use an md5 as array index to avoid having special characters | |||
| in the name attribute (see bug #1746964 ) #} | |||
| {% set myfield_md5 = md5(myfield) %} | |||
| {% set myfield_md5 = save_row[i]['Hash'] %} | |||
There was a problem hiding this comment.
This value seems to be empty for me.
There was a problem hiding this comment.
Fixed it, it really was empty. Now I'm using the other array (column_array).
Adapt templates to remove md5 from PhpFuncionsExtension.php Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
|
Merged, thanks for your contribution! |
|
@laps15 You have maybe introduced a bug. |
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
Fix bug reported on pull request #14305
Adapt templates to remove md5 from PhpFuncionsExtension.php
Signed-off-by: Leonardo Strozzi laps15@inf.ufpr.br
Before submitting pull request, please check that every commit: