Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove md5 twig extension #14305
Conversation
| @@ -1,5 +1,6 @@ | ||
| <tr> | ||
| <td class="vmiddle"> | ||
| <h1>{{ myfield_md5 }}</h1> |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| @@ -654,6 +654,8 @@ protected function displayTableList() | ||
| Template::get('database/structure/structure_table_row') | ||
| ->render( | ||
| array( | ||
| 'table_name_hash' => md5($current_table['TABLE_NAME']), | ||
| 'db_table_name_hash' => md5($this->db.$current_table['TABLE_NAME']), |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
laps15
May 18, 2018
Contributor
Done! There was a '.' missing between the db name ante the table name, fixed that too.
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
May 18, 2018
•
Codecov Report
@@ Coverage Diff @@
## master #14305 +/- ##
============================================
- Coverage 50.45% 50.44% -0.01%
- Complexity 14410 14411 +1
============================================
Files 502 502
Lines 67019 67025 +6
============================================
- Hits 33814 33813 -1
- Misses 33205 33212 +7 |
| @@ -117,7 +117,7 @@ | ||
| {% set myfield = save_row[i]['Field'] %} | ||
| {# Use an md5 as array index to avoid having special characters | ||
| in the name attribute (see bug #1746964 ) #} | ||
| {% set myfield_md5 = md5(myfield) %} | ||
| {% set myfield_md5 = save_row[i]['Hash'] %} |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
laps15
May 22, 2018
Contributor
Fixed it, it really was empty. Now I'm using the other array (column_array).
mauriciofauth
merged commit 2d5825d
into
phpmyadmin:master
May 23, 2018
4 of 6 checks passed
codecov/patch
0% of diff hit (target 50.45%)
Details
codecov/project
50.44% (-0.01%) compared to 83f4336
Details
Codacy/PR Quality Review
Up to standards. A positive pull request.
Details
DCO
All commits have a DCO sign-off from the author
Details
Scrutinizer
Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
|
Merged, thanks for your contribution! |
mauriciofauth
self-assigned this
May 23, 2018
mauriciofauth
added this to the 5.0.0 milestone
May 23, 2018
This comment has been minimized.
This comment has been minimized.
|
@laps15 You have maybe introduced a bug. |
added a commit
to laps15/phpmyadmin
that referenced
this pull request
May 30, 2018
added a commit
to laps15/phpmyadmin
that referenced
this pull request
May 30, 2018
added a commit
to laps15/phpmyadmin
that referenced
this pull request
May 30, 2018
added a commit
that referenced
this pull request
May 30, 2018
laps15
deleted the
laps15:refactor
branch
Jun 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
laps15 commentedMay 18, 2018
Adapt templates to remove md5 from PhpFuncionsExtension.php
Signed-off-by: Leonardo Strozzi laps15@inf.ufpr.br
Before submitting pull request, please check that every commit: