Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SVG Icons and Logos #14318

Merged
merged 7 commits into from Nov 29, 2018
Merged

Add SVG Icons and Logos #14318

merged 7 commits into from Nov 29, 2018

Conversation

@mkkeck
Copy link
Contributor

mkkeck commented May 23, 2018

  • New folder resources for source files
    • SVG-Icons
    • SVG-Logos

Signed-off-by: Michael Keck github@michaelkeck.de

mkkeck added 6 commits Apr 20, 2018
Merged across forks
@phpmyadmin-bot

This comment has been minimized.

Copy link

phpmyadmin-bot commented on 62e334c May 23, 2018

This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check contributing documentation for more information.

@codecov

This comment has been minimized.

Copy link

codecov bot commented May 23, 2018

Codecov Report

Merging #14318 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #14318   +/-   ##
=========================================
  Coverage     50.42%   50.42%           
  Complexity    14416    14416           
=========================================
  Files           500      500           
  Lines         68097    68097           
=========================================
  Hits          34341    34341           
  Misses        33756    33756
@ibennetch

This comment has been minimized.

Copy link
Member

ibennetch commented Jun 2, 2018

These are wonderful, thank you.

I do wonder if they would be better placed in https://github.com/phpmyadmin/data instead, but on the other hand, it doesn't really bother me to have them here.

@mkkeck

This comment has been minimized.

Copy link
Contributor Author

mkkeck commented Jun 2, 2018

@ibennetch
I think resources would be better than data. Data would be perhaps reserved for user data or app data. Resources means, extra content and files, in raw format. But it doesn't bother me too.

@stale

This comment has been minimized.

Copy link

stale bot commented Aug 3, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 3, 2018
@williamdes

This comment has been minimized.

Copy link
Member

williamdes commented Aug 3, 2018

No update on this great PR ?
/rebase /squash ?

@stale stale bot removed the wontfix label Aug 3, 2018
@mkkeck

This comment has been minimized.

Copy link
Contributor Author

mkkeck commented Aug 3, 2018

Hi all,
Sorry I am too busy at this moment. I am back in September or October.

Kind regards
Michael

@stale stale bot added the wontfix label Oct 2, 2018
@williamdes williamdes added enhancement and removed wontfix labels Oct 2, 2018
@mauriciofauth

This comment has been minimized.

Copy link
Member

mauriciofauth commented Oct 2, 2018

I really liked those icons. I hope we can use them soon.

We already have some logos on https://github.com/phpmyadmin/data, what do you think of them? And what do you think of transferring those files to that repository?

One more thing, your commit does not have the Signed-off-by line, which indicates that you agree with phpMyAdmin Developer's Certificate of Origin. This ensures that the work you're submitting is your own creation.

@phpmyadmin phpmyadmin deleted a comment from stale bot Oct 2, 2018
@mkkeck

This comment has been minimized.

Copy link
Contributor Author

mkkeck commented Oct 3, 2018

Sorry for late response. I am too busy at the moment, and one more big problem: My workstation is damaged (hardware failures) last week, so I've to buy some new soon as possible.

One more thing, your commit does not have the Signed-off-by line, which indicates that you agree with phpMyAdmin Developer's Certificate of Origin. This ensures that the work you're submitting is your own creation.

I've done as descriped, but how can I fix?

We already have some logos on https://github.com/phpmyadmin/data, what do you think of them? And what do you think of transferring those files to that repository?

Yes I know. I've made these to ;). The newer ones are made mainly but not only for the app.

@mauriciofauth

This comment has been minimized.

Copy link
Member

mauriciofauth commented Oct 6, 2018

I've done as descriped, but how can I fix?

You can add the signature line with git commit -s, but for this time you can add a comment with the signature line in this PR. For example:

Signed-off-by: Random Developer <random@developer.example.org>
@mkkeck

This comment has been minimized.

Copy link
Contributor Author

mkkeck commented Nov 13, 2018

Signed-off-by: Michael Keck github@michaelkeck.de

@williamdes

This comment has been minimized.

Copy link
Member

williamdes commented Nov 26, 2018

@mauriciofauth mauriciofauth changed the title SVG-Icons and -Logos Add SVG Icons and Logos Nov 29, 2018
@mauriciofauth mauriciofauth merged commit 25d20cd into phpmyadmin:master Nov 29, 2018
5 of 6 checks passed
5 of 6 checks passed
DCO The sign-off is missing.
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
codecov/patch Coverage not affected when comparing 2a34c01...290e101
Details
codecov/project 50.42% remains the same compared to 2a34c01
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mauriciofauth

This comment has been minimized.

Copy link
Member

mauriciofauth commented Nov 29, 2018

Merged, thank you for your contribution!

@mauriciofauth mauriciofauth self-assigned this Nov 29, 2018
@mauriciofauth mauriciofauth added this to the 5.0.0 milestone Nov 29, 2018
mauriciofauth added a commit to phpmyadmin/data that referenced this pull request Nov 29, 2018
phpmyadmin/phpmyadmin#14318

Signed-off-by: Michael Keck <github@michaelkeck.de>
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.