New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #14327 fixed #14328

Merged
merged 2 commits into from Jul 4, 2018

Conversation

Projects
None yet
4 participants
@Piyush3079
Contributor

Piyush3079 commented May 25, 2018

Editing server variable not showing save or cancel option issue. Fixes #14327

Signed-off-by: Piyush Vijay piyushvijay.1997@gmail.com

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
Editing server variable not showing save or cancel option issue #14327:…
… fixed

Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
@codecov

This comment has been minimized.

codecov bot commented May 25, 2018

Codecov Report

Merging #14328 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #14328   +/-   ##
=========================================
  Coverage     50.45%   50.45%           
  Complexity    14411    14411           
=========================================
  Files           502      502           
  Lines         67028    67028           
=========================================
  Hits          33817    33817           
  Misses        33211    33211

@Piyush3079 Piyush3079 changed the title from Ossue #14327 fixed to Issue #14327 fixed May 26, 2018

@devenbansod

This comment has been minimized.

Member

devenbansod commented May 26, 2018

Thanks @Piyush3079 for the PR.

I tried this with 4.6.6, it showed up like this:
screen shot 2018-05-26 at 7 39 00 pm

With your patch on QA_4_8, it looks like:
screen shot 2018-05-26 at 7 39 27 pm

Expected?

Styling of the links improved.
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
@Piyush3079

This comment has been minimized.

Contributor

Piyush3079 commented May 28, 2018

I have made the corrections.

@lem9

This comment has been minimized.

Contributor

lem9 commented Jun 22, 2018

@devenbansod Can you retest?

@mauriciofauth mauriciofauth merged commit bd7d4ca into phpmyadmin:master Jul 4, 2018

6 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
DCO All commits have a DCO sign-off from the author
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
codecov/patch Coverage not affected when comparing 3908ae2...9f9c4aa
Details
codecov/project 50.45% remains the same compared to 3908ae2
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mauriciofauth

This comment has been minimized.

Member

mauriciofauth commented Jul 4, 2018

Merged, thanks for your contribution!

@mauriciofauth mauriciofauth self-assigned this Jul 4, 2018

@mauriciofauth mauriciofauth added this to the 4.8.3 milestone Jul 4, 2018

mauriciofauth added a commit that referenced this pull request Jul 4, 2018

Fix editing server variable not showing save or cancel option (#14328)
* Editing server variable not showing save or cancel option issue #14327: fixed
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

* Styling of the links improved.
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
(cherry picked from commit bd7d4ca)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment