New features for csv import plugin #14330

aroralakshya · 2018-05-26T15:06:44Z

Following new features have been added in the csv import plugin:

For a new import, user can now directly enter the table or database name at the time of import
Partial import. User can enter how many rows they want to import.
Signed-Off-By: Lakshay arora arora.lakshya123@gmail.com

Before submitting pull request, please check that every commit:

Has proper Signed-Off-By
Has commit message which describes it
Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
Any new functionality is covered by tests

ibennetch · 2018-06-02T14:31:30Z

js/import.js

@@ -60,6 +60,8 @@ AJAX.registerOnload('import.js', function () {
        var radioLocalImport = $('#radio_local_import_file');
        var radioImport = $('#radio_import_file');
        var fileMsg = '<div class="error"><img src="themes/dot.gif" title="" alt="" class="icon ic_s_error" /> ' + PMA_messages.strImportDialogMessage + '</div>';
+        var wrongTblNameMsg = '<div class="error"><img src="themes/dot.gif" title="" alt="" class="icon ic_s_error" />Please enter a valid table name</div>';


We should make these strings translatable; see the line above for an example. Basically, we put the actual string in https://github.com/phpmyadmin/phpmyadmin/blob/master/js/messages.php and then reference it from here; that way the translators can also put it in their own language.

MauricioFauth · 2018-07-03T23:28:07Z

js/functions.js

+            data: params,
+            success: function (data) {
+                if (data.success) {
+                    $("<h3>You can change the table structure here</h3>" + data.message).insertAfter($("#new_csv_db_name").parent());


I think you forgot to make this string translatable.

…csv file. Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

Following new features have been added in the csv import plugin: 1. For a new import, user can now directly enter the table or database name at the time of import 2. Partial import. User can enter how many rows they want to import. Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

1. For a new import, user can now directly enter the table or database name at the time of import 2. Partial import. User can enter how many rows they want to import. 3. Show the form to edit table structure after import(undecided). Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

aroralakshya · 2018-08-06T12:05:45Z

Applied changes and solved merge conflicts. I'll work on tests as soon as travis finishes.

…import Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

ibennetch · 2018-08-08T11:08:13Z

I think you forgot to make <h3>You can change the table structure here</h3> translatable here, other than that I think you got all of the requested changes.

codecov · 2018-08-09T10:34:50Z

Codecov Report

Merging #14330 into master will increase coverage by 0.33%.
The diff coverage is 84.37%.

@@             Coverage Diff              @@
##             master   #14330      +/-   ##
============================================
+ Coverage      49.7%   50.03%   +0.33%     
- Complexity    13871    14447     +576     
============================================
  Files           498      498              
  Lines         66803    67342     +539     
============================================
+ Hits          33204    33696     +492     
- Misses        33599    33646      +47

aroralakshya · 2018-08-09T10:34:56Z

Done

MauricioFauth · 2018-08-15T02:27:21Z

js/import.js

+            }
+            if($("#text_csv_new_db_name").length > 0) {
+                var newDBName = $("#text_csv_new_db_name").val();
+                if(newDBName.length > 0 && $.trim(newDBName).length === 0) {


Some lines caused ESLint to fail. See: https://travis-ci.org/phpmyadmin/phpmyadmin/jobs/413992898#L742

These linting errors are in many of my PRs, it says it can be fixed using --fix option, how can I use this, I even asked this on the mailing list but got no reply.

Probably ./node_modules/.bin/eslint js/import.js --fix will do what you're after. Sorry I missed your email!

And if you do not have the node_modules directory, you need to run the yarn install command

Signed-off-by: Lakshay arora <arora.lakshya123@gmail.com>

aroralakshya · 2018-08-18T08:39:22Z

I've fixed lint and other tests, but I don't understand this new selenium error?

MauricioFauth · 2018-10-06T15:43:56Z

Merged, thanks for your contribution!

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com> Signed-off-by: Vincent Horváth <win9400@gmail.com>

Following new features have been added in the csv import plugin: 1. For a new import, user can now directly enter the table or database name at the time of import 2. Partial import. User can enter how many rows they want to import. Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com> Signed-off-by: Vincent Horváth <win9400@gmail.com>

aroralakshya changed the title ~~Enh 2~~ New features for csv import plugin May 26, 2018

ibennetch requested changes Jun 2, 2018

View reviewed changes

MauricioFauth requested changes Jul 3, 2018

View reviewed changes

aroralakshya added 3 commits August 6, 2018 17:04

Add an option to provide table and database name when importing from …

3943f44

…csv file. Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

aroralakshya added 2 commits August 8, 2018 15:51

Make Dialog messages translatable, add partial import feature to tbl_…

498979d

…import Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

Fix tests

2c09c36

Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

MauricioFauth requested changes Aug 15, 2018

View reviewed changes

Remove options to view and change table structure after upload

becfbf0

Signed-off-by: Lakshay arora <arora.lakshya123@gmail.com>

MauricioFauth approved these changes Oct 6, 2018

View reviewed changes

MauricioFauth merged commit 19cbb34 into phpmyadmin:master Oct 6, 2018

MauricioFauth self-assigned this Oct 6, 2018

MauricioFauth added this to the 5.0.0 milestone Oct 6, 2018

MauricioFauth added a commit that referenced this pull request Oct 6, 2018

Add ChangeLog entry for #14330

4d94b1b

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>

wincdev pushed a commit to wincdev/phpmyadmin that referenced this pull request Oct 8, 2018

Add ChangeLog entry for phpmyadmin#14330

06c0423

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com> Signed-off-by: Vincent Horváth <win9400@gmail.com>

wincdev pushed a commit to wincdev/phpmyadmin that referenced this pull request Oct 8, 2018

Add ChangeLog entry for phpmyadmin#14330

35f1efc

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com> Signed-off-by: Vincent Horváth <win9400@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New features for csv import plugin #14330

New features for csv import plugin #14330

aroralakshya commented May 26, 2018 •

edited

ibennetch Jun 2, 2018

MauricioFauth Jul 3, 2018

aroralakshya commented Aug 6, 2018

ibennetch commented Aug 8, 2018 •

edited

codecov bot commented Aug 9, 2018 •

edited

aroralakshya commented Aug 9, 2018

MauricioFauth Aug 15, 2018

aroralakshya Aug 15, 2018

ibennetch Aug 15, 2018

MauricioFauth Aug 16, 2018

aroralakshya commented Aug 18, 2018

MauricioFauth commented Oct 6, 2018

New features for csv import plugin #14330

New features for csv import plugin #14330

Conversation

aroralakshya commented May 26, 2018 • edited

ibennetch Jun 2, 2018

Choose a reason for hiding this comment

MauricioFauth Jul 3, 2018

Choose a reason for hiding this comment

aroralakshya commented Aug 6, 2018

ibennetch commented Aug 8, 2018 • edited

codecov bot commented Aug 9, 2018 • edited

Codecov Report

aroralakshya commented Aug 9, 2018

MauricioFauth Aug 15, 2018

Choose a reason for hiding this comment

aroralakshya Aug 15, 2018

Choose a reason for hiding this comment

ibennetch Aug 15, 2018

Choose a reason for hiding this comment

MauricioFauth Aug 16, 2018

Choose a reason for hiding this comment

aroralakshya commented Aug 18, 2018

MauricioFauth commented Oct 6, 2018

aroralakshya commented May 26, 2018 •

edited

ibennetch commented Aug 8, 2018 •

edited

codecov bot commented Aug 9, 2018 •

edited