New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor db central columns templates #14353

Merged
merged 1 commit into from Jun 4, 2018

Conversation

Projects
None yet
2 participants
@laps15
Contributor

laps15 commented Jun 3, 2018

Signed-off-by: Leonardo Strozzi laps15@inf.ufpr.br

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
Refactor db central columns templates
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Jun 3, 2018

Codecov Report

Merging #14353 into master will decrease coverage by <.01%.
The diff coverage is 50.72%.

@@             Coverage Diff              @@
##             master   #14353      +/-   ##
============================================
- Coverage     50.42%   50.42%   -0.01%     
+ Complexity    14416    14411       -5     
============================================
  Files           500      500              
  Lines         68097    67936     -161     
============================================
- Hits          34341    34258      -83     
+ Misses        33756    33678      -78

codecov bot commented Jun 3, 2018

Codecov Report

Merging #14353 into master will decrease coverage by <.01%.
The diff coverage is 50.72%.

@@             Coverage Diff              @@
##             master   #14353      +/-   ##
============================================
- Coverage     50.42%   50.42%   -0.01%     
+ Complexity    14416    14411       -5     
============================================
  Files           500      500              
  Lines         68097    67936     -161     
============================================
- Hits          34341    34258      -83     
+ Misses        33756    33678      -78

@mauriciofauth mauriciofauth merged commit 463cc03 into phpmyadmin:master Jun 4, 2018

5 of 6 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
DCO All commits have a DCO sign-off from the author
Details
Scrutinizer Analysis: 7 new issues, 3 updated code elements – Tests: passed
Details
codecov/patch 50.72% of diff hit (target 50.42%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +0.29% compared to 2a34c01
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mauriciofauth

This comment has been minimized.

Show comment
Hide comment
@mauriciofauth

mauriciofauth Jun 4, 2018

Member

Merged, thanks for your contribution!

Member

mauriciofauth commented Jun 4, 2018

Merged, thanks for your contribution!

@mauriciofauth mauriciofauth self-assigned this Jun 4, 2018

@mauriciofauth mauriciofauth added this to the 5.0.0 milestone Jun 4, 2018

@laps15 laps15 deleted the laps15:refactor branch Jun 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment