New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor db designer templates #14372

Merged
merged 1 commit into from Jun 12, 2018

Conversation

Projects
None yet
3 participants
@laps15
Contributor

laps15 commented Jun 9, 2018

Signed-off-by: Leonardo Strozzi laps15@inf.ufpr.br

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Jun 9, 2018

Codecov Report

Merging #14372 into master will increase coverage by 0.01%.
The diff coverage is 10.16%.

@@             Coverage Diff              @@
##             master   #14372      +/-   ##
============================================
+ Coverage     50.41%   50.43%   +0.01%     
- Complexity    14414    14415       +1     
============================================
  Files           500      500              
  Lines         67925    67902      -23     
============================================
  Hits          34245    34245              
+ Misses        33680    33657      -23

codecov bot commented Jun 9, 2018

Codecov Report

Merging #14372 into master will increase coverage by 0.01%.
The diff coverage is 10.16%.

@@             Coverage Diff              @@
##             master   #14372      +/-   ##
============================================
+ Coverage     50.41%   50.43%   +0.01%     
- Complexity    14414    14415       +1     
============================================
  Files           500      500              
  Lines         67925    67902      -23     
============================================
  Hits          34245    34245              
+ Misses        33680    33657      -23
public function getWhereQueryPanel()
public function getHtmlForMain(
string $db,
string $getDb,

This comment has been minimized.

@williamdes

williamdes Jun 9, 2018

Member

CI failed because :
ERROR: The "get_db" @param tag variable name is wrong (should be "getDb") on "PhpMyAdmin\Database\Designer::getHtmlForMain" in ./libraries/classes/Database/Designer.php:320

@williamdes

williamdes Jun 9, 2018

Member

CI failed because :
ERROR: The "get_db" @param tag variable name is wrong (should be "getDb") on "PhpMyAdmin\Database\Designer::getHtmlForMain" in ./libraries/classes/Database/Designer.php:320

Finish db designer refactor
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>

@mauriciofauth mauriciofauth merged commit be5a01d into phpmyadmin:master Jun 12, 2018

4 of 6 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
codecov/patch 10.16% of diff hit (target 50.41%)
Details
DCO All commits have a DCO sign-off from the author
Details
Scrutinizer Analysis: 2 new issues, 1 updated code elements – Tests: passed
Details
codecov/project 50.43% (+0.01%) compared to 86fcc46
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mauriciofauth

This comment has been minimized.

Show comment
Hide comment
@mauriciofauth

mauriciofauth Jun 12, 2018

Member

Merged, thanks for your contribution!

Member

mauriciofauth commented Jun 12, 2018

Merged, thanks for your contribution!

@mauriciofauth mauriciofauth self-assigned this Jun 12, 2018

@mauriciofauth mauriciofauth added this to the 5.0.0 milestone Jun 12, 2018

@laps15 laps15 deleted the laps15:refactor branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment