Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor database templates #14415

Merged
merged 4 commits into from Jun 21, 2018

Conversation

Projects
None yet
2 participants
@laps15
Copy link
Contributor

laps15 commented Jun 21, 2018

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

laps15 added some commits Jun 19, 2018

Refactor db search templates
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
Change search test
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>

@laps15 laps15 changed the title Refactor Refactor database templates Jun 21, 2018

laps15 added some commits Jun 20, 2018

Refactor Database Structure templates
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
Fix Qbe casting error
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>

@laps15 laps15 force-pushed the laps15:refactor branch from 9a0f80e to 326151a Jun 21, 2018

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jun 21, 2018

Codecov Report

Merging #14415 into master will increase coverage by 0.01%.
The diff coverage is 12.5%.

@@             Coverage Diff              @@
##             master   #14415      +/-   ##
============================================
+ Coverage      50.4%   50.41%   +0.01%     
+ Complexity    14421    14419       -2     
============================================
  Files           500      500              
  Lines         67928    67906      -22     
============================================
- Hits          34239    34237       -2     
+ Misses        33689    33669      -20

@mauriciofauth mauriciofauth merged commit ec4911d into phpmyadmin:master Jun 21, 2018

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
DCO All commits have a DCO sign-off from the author
Details
Scrutinizer Analysis: 2 updated code elements – Tests: passed
Details
@mauriciofauth

This comment has been minimized.

Copy link
Member

mauriciofauth commented Jun 21, 2018

Merged, thanks for your contribution!

@mauriciofauth mauriciofauth self-assigned this Jun 21, 2018

@mauriciofauth mauriciofauth added this to the 5.0.0 milestone Jun 21, 2018

@laps15 laps15 deleted the laps15:refactor branch Jun 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.