New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically add index while editing an existing row and setting auto increment #14417
Conversation
Remove popup when adding A_I during column addition. Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #14417 +/- ##
============================================
- Coverage 50.05% 50.05% -0.01%
- Complexity 13945 13949 +4
============================================
Files 498 498
Lines 66653 66662 +9
============================================
+ Hits 33365 33368 +3
- Misses 33288 33294 +6 |
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
|
This is odd to me, I fixed one error with Selenium tests for you but there are two that don't seem to me to be related. Do you have any thought about the errors shown around https://travis-ci.org/phpmyadmin/phpmyadmin/jobs/398511173#L859 ? |
|
isn't this related to #13621 |
|
I think it is unrelated. The failing tests are different and Michal marked those tests to be skipped. When I look in Travis CI at current master, there weren't any failures but these failed in your pull request so it seems that it's related to that. I haven't looked at the actual code results to see what's going on, it definitely might be unrelated to your changes. |
|
I tried looking into the tests-
which is quite strange because #input_username textbox is used to input username in login form. So I feel this is unrelated to my changes.
Which is expected after |
|
@ibennetch I've fixed tests. Only lint tests failed, which can be fixed by --fix. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Merged, thanks for your contribution! |
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
This PR -
Before submitting pull request, please check that every commit: