Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add index while editing an existing row and setting auto increment #14417

Merged
merged 5 commits into from Oct 23, 2018
Merged

Conversation

aroralakshya
Copy link
Contributor

@aroralakshya aroralakshya commented Jun 21, 2018

This PR -

  1. Automates the addition of PRIMARY KEY index when user tries to edit an existing row and set AUTO INCREMENT.
  2. Disables the popup on insert new column page when user sets AUTO INCREMENT and automatically sets the index to PRIMARY KEY.

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

Remove popup when adding A_I during column addition.
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
@codecov
Copy link

codecov bot commented Jun 22, 2018

Codecov Report

Merging #14417 into master will decrease coverage by <.01%.
The diff coverage is 36.36%.

@@             Coverage Diff              @@
##             master   #14417      +/-   ##
============================================
- Coverage     50.05%   50.05%   -0.01%     
- Complexity    13945    13949       +4     
============================================
  Files           498      498              
  Lines         66653    66662       +9     
============================================
+ Hits          33365    33368       +3     
- Misses        33288    33294       +6

Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
@ibennetch
Copy link
Member

This is odd to me, I fixed one error with Selenium tests for you but there are two that don't seem to me to be related. Do you have any thought about the errors shown around https://travis-ci.org/phpmyadmin/phpmyadmin/jobs/398511173#L859 ?

@aroralakshya
Copy link
Contributor Author

isn't this related to #13621

@ibennetch
Copy link
Member

ibennetch commented Jun 30, 2018

I think it is unrelated. The failing tests are different and Michal marked those tests to be skipped. When I look in Travis CI at current master, there weren't any failures but these failed in your pull request so it seems that it's related to that. I haven't looked at the actual code results to see what's going on, it definitely might be unrelated to your changes.

@aroralakshya
Copy link
Contributor Author

aroralakshya commented Jul 1, 2018

I tried looking into the tests-

  1. The first one tries to drop a table, and asserts if it is dropped, but the test shows -

Unable to locate element: {"method":"id","selector":"input_username"}

which is quite strange because #input_username textbox is used to input username in login form. So I feel this is unrelated to my changes.
2. The second one tries to submit an empty sql query and asserts if it shows an error alert, the test shows-

element not visible

Which is expected after
(e5ff7f3), because after this commit, sql query field is never left blank, when the test tries to submit the query, it's never empty. So I feel this one is also unrelated to my changes.

@aroralakshya
Copy link
Contributor Author

@ibennetch I've fixed tests. Only lint tests failed, which can be fixed by --fix.

Signed-off-by: Lakshay arora <arora.lakshya123@gmail.com>
@stale
Copy link

stale bot commented Oct 15, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 15, 2018
@MauricioFauth MauricioFauth self-requested a review October 16, 2018 17:20
@stale stale bot removed the wontfix label Oct 16, 2018
@MauricioFauth MauricioFauth self-assigned this Oct 23, 2018
@MauricioFauth MauricioFauth added this to the 5.0.0 milestone Oct 23, 2018
@MauricioFauth MauricioFauth merged commit 2a07cee into phpmyadmin:master Oct 23, 2018
@MauricioFauth
Copy link
Member

Merged, thanks for your contribution!

MauricioFauth added a commit that referenced this pull request Oct 23, 2018
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants