New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor db_tracking templates #14428

Merged
merged 2 commits into from Jun 26, 2018

Conversation

Projects
None yet
2 participants
@laps15
Contributor

laps15 commented Jun 25, 2018

Signed-off-by: Leonardo Strozzi laps15@inf.ufpr.br

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Jun 25, 2018

Codecov Report

Merging #14428 into master will increase coverage by <.01%.
The diff coverage is 4.44%.

@@             Coverage Diff              @@
##             master   #14428      +/-   ##
============================================
+ Coverage     50.42%   50.43%   +<.01%     
- Complexity    14421    14422       +1     
============================================
  Files           500      500              
  Lines         67912    67899      -13     
============================================
  Hits          34243    34243              
+ Misses        33669    33656      -13

codecov bot commented Jun 25, 2018

Codecov Report

Merging #14428 into master will increase coverage by <.01%.
The diff coverage is 4.44%.

@@             Coverage Diff              @@
##             master   #14428      +/-   ##
============================================
+ Coverage     50.42%   50.43%   +<.01%     
- Complexity    14421    14422       +1     
============================================
  Files           500      500              
  Lines         67912    67899      -13     
============================================
  Hits          34243    34243              
+ Misses        33669    33656      -13

laps15 added some commits Jun 26, 2018

Fix code sniffer ServerDatabasesController error
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
Refactor db_tracking templates
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>

@mauriciofauth mauriciofauth merged commit a5c14e4 into phpmyadmin:master Jun 26, 2018

4 of 5 checks passed

codecov/patch 4.44% of diff hit (target 50.42%)
Details
DCO All commits have a DCO sign-off from the author
Details
Scrutinizer Analysis: 2 new issues, 1 updated code elements – Tests: passed
Details
codecov/project 50.43% (+<.01%) compared to 3ea6fec
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mauriciofauth

This comment has been minimized.

Show comment
Hide comment
@mauriciofauth

mauriciofauth Jun 26, 2018

Member

Merged, thanks for your contribution!

Member

mauriciofauth commented Jun 26, 2018

Merged, thanks for your contribution!

@mauriciofauth mauriciofauth self-assigned this Jun 26, 2018

@mauriciofauth mauriciofauth added this to the 5.0.0 milestone Jun 26, 2018

@laps15 laps15 deleted the laps15:db_tracking_refactor branch Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment