New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds features discussed in #13023 #14436

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@nulll-pointer
Contributor

nulll-pointer commented Jun 28, 2018

Fixes #13023

  1. Show ajax errors at the bottom of the page, instead of showing them in a popup.
  2. Add copy query button for errors in processing sql queries.
    Signed-Off-By: Lakshay arora arora.lakshya123@gmail.com

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
Adds features discussed in #13023
1. Show ajax errors at the bottom of the page, instead of showing them in a popup.
2. Add copy query button for errors in processing sql queries.
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
@codecov

This comment has been minimized.

codecov bot commented Jun 28, 2018

Codecov Report

Merging #14436 into master will increase coverage by 0.34%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master   #14436      +/-   ##
============================================
+ Coverage      49.7%   50.04%   +0.34%     
- Complexity    13871    14435     +564     
============================================
  Files           498      500       +2     
  Lines         66803    67343     +540     
============================================
+ Hits          33204    33705     +501     
- Misses        33599    33638      +39

nulll-pointer added some commits Jun 28, 2018

Show Copy status
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
Fix tests
Signed-off-by: Lakshay arora <arora.lakshya123@gmail.com>

@mauriciofauth mauriciofauth self-requested a review Oct 23, 2018

Show resolved Hide resolved js/functions.js

@mauriciofauth mauriciofauth self-assigned this Nov 15, 2018

@mauriciofauth mauriciofauth added this to the 5.0.0 milestone Nov 15, 2018

@mauriciofauth

This comment has been minimized.

Member

mauriciofauth commented Nov 15, 2018

Merged, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment