New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor server templates #14442

Merged
merged 5 commits into from Jun 30, 2018

Conversation

Projects
None yet
2 participants
@laps15
Contributor

laps15 commented Jun 29, 2018

This pull request is under construction yet, as server_engines tests are getting in my way

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

laps15 added some commits Jun 26, 2018

Refactor server_databases templates
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
Refactor server_variables templates
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Jun 29, 2018

Codecov Report

Merging #14442 into master will decrease coverage by 0.02%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##             master   #14442      +/-   ##
============================================
- Coverage     50.43%    50.4%   -0.03%     
- Complexity    14426    14427       +1     
============================================
  Files           500      500              
  Lines         67907    67903       -4     
============================================
- Hits          34250    34228      -22     
- Misses        33657    33675      +18

codecov bot commented Jun 29, 2018

Codecov Report

Merging #14442 into master will decrease coverage by 0.02%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##             master   #14442      +/-   ##
============================================
- Coverage     50.43%    50.4%   -0.03%     
- Complexity    14426    14427       +1     
============================================
  Files           500      500              
  Lines         67907    67903       -4     
============================================
- Hits          34250    34228      -22     
- Misses        33657    33675      +18

laps15 added some commits Jun 29, 2018

Refactor server_plugins templates
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
Refactor server_engines templates
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
Fix tests for server_engine
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>

@mauriciofauth mauriciofauth merged commit 2334119 into phpmyadmin:master Jun 30, 2018

2 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
DCO All commits have a DCO sign-off from the author
Details
Scrutinizer Analysis: 4 new issues, 4 updated code elements – Tests: passed
Details
@mauriciofauth

This comment has been minimized.

Show comment
Hide comment
@mauriciofauth

mauriciofauth Jun 30, 2018

Member

Merged, thanks for your contribution!

Member

mauriciofauth commented Jun 30, 2018

Merged, thanks for your contribution!

@mauriciofauth mauriciofauth self-assigned this Jun 30, 2018

@mauriciofauth mauriciofauth added this to the 5.0.0 milestone Jun 30, 2018

@laps15 laps15 deleted the laps15:refactor_server branch Jul 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment