Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tables' tamplates #14471

Merged
merged 3 commits into from Jul 10, 2018

Conversation

Projects
None yet
2 participants
@laps15
Copy link
Contributor

laps15 commented Jul 8, 2018

Before submitting pull request, please check that every commit:

Pull request under construction, waiting for the rest of refactors.

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

laps15 added some commits Jul 6, 2018

Refactor table_tracking main tamplates
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
Adapt table tracking main tests
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
Fix php code sniffer errors
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>

@laps15 laps15 force-pushed the laps15:refactor_tables branch from e5b6816 to 3b87465 Jul 8, 2018

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jul 8, 2018

Codecov Report

Merging #14471 into master will decrease coverage by 0.04%.
The diff coverage is 79.48%.

@@             Coverage Diff              @@
##             master   #14471      +/-   ##
============================================
- Coverage     50.48%   50.43%   -0.05%     
+ Complexity    14430    14428       -2     
============================================
  Files           500      500              
  Lines         67923    67846      -77     
============================================
- Hits          34292    34220      -72     
+ Misses        33631    33626       -5

@mauriciofauth mauriciofauth merged commit ce66ab2 into phpmyadmin:master Jul 10, 2018

5 of 6 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
DCO All commits have a DCO sign-off from the author
Details
Scrutinizer Analysis: 2 new issues, 2 updated code elements – Tests: passed
Details
codecov/patch 79.48% of diff hit (target 50.48%)
Details
codecov/project Absolute coverage decreased by -0.04% but relative coverage increased by +29% compared to cf8e559
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mauriciofauth

This comment has been minimized.

Copy link
Member

mauriciofauth commented Jul 10, 2018

Merged, thanks for your contribution!

@mauriciofauth mauriciofauth self-assigned this Jul 10, 2018

@mauriciofauth mauriciofauth added this to the 5.0.0 milestone Jul 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.