New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor table search templates #14480

Merged
merged 2 commits into from Jul 12, 2018

Conversation

Projects
None yet
2 participants
@laps15
Contributor

laps15 commented Jul 11, 2018

Signed-off-by: Leonardo Strozzi laps15@inf.ufpr.br

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
Refactor table search templates
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Jul 11, 2018

Codecov Report

Merging #14480 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #14480   +/-   ##
=========================================
  Coverage     50.43%   50.43%           
  Complexity    14428    14428           
=========================================
  Files           500      500           
  Lines         67846    67846           
=========================================
  Hits          34220    34220           
  Misses        33626    33626

codecov bot commented Jul 11, 2018

Codecov Report

Merging #14480 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #14480   +/-   ##
=========================================
  Coverage     50.43%   50.43%           
  Complexity    14428    14428           
=========================================
  Files           500      500           
  Lines         67846    67846           
=========================================
  Hits          34220    34220           
  Misses        33626    33626
Merge table structure tamplates
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>

@mauriciofauth mauriciofauth merged commit c2c5bfc into phpmyadmin:master Jul 12, 2018

6 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
DCO All commits have a DCO sign-off from the author
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
codecov/patch Coverage not affected when comparing db5ecb3...108f445
Details
codecov/project 50.43% remains the same compared to db5ecb3
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mauriciofauth mauriciofauth self-assigned this Jul 12, 2018

@mauriciofauth mauriciofauth added this to the 5.0.0 milestone Jul 12, 2018

@mauriciofauth

This comment has been minimized.

Show comment
Hide comment
@mauriciofauth

mauriciofauth Jul 12, 2018

Member

Merged, thanks for your contribution!

Member

mauriciofauth commented Jul 12, 2018

Merged, thanks for your contribution!

@laps15 laps15 deleted the laps15:refactor_tables branch Jul 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment