New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor table secondary tabs tamplate #14483

Merged
merged 1 commit into from Jul 13, 2018

Conversation

Projects
None yet
3 participants
@laps15
Contributor

laps15 commented Jul 13, 2018

Implements inheritance on relation and structure templates

Signed-off-by: Leonardo Strozzi laps15@inf.ufpr.br

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
Refactor table secondary tabs tamplate
Implements inheritance on relation and structure templates

Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Jul 13, 2018

Codecov Report

Merging #14483 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master   #14483      +/-   ##
============================================
+ Coverage     50.43%   50.44%   +<.01%     
  Complexity    14428    14428              
============================================
  Files           500      500              
  Lines         67846    67842       -4     
============================================
  Hits          34220    34220              
+ Misses        33626    33622       -4

codecov bot commented Jul 13, 2018

Codecov Report

Merging #14483 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master   #14483      +/-   ##
============================================
+ Coverage     50.43%   50.44%   +<.01%     
  Complexity    14428    14428              
============================================
  Files           500      500              
  Lines         67846    67842       -4     
============================================
  Hits          34220    34220              
+ Misses        33626    33622       -4

@mauriciofauth mauriciofauth merged commit 1079140 into phpmyadmin:master Jul 13, 2018

5 of 6 checks passed

codecov/patch 0% of diff hit (target 50.43%)
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
DCO All commits have a DCO sign-off from the author
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
codecov/project 50.44% (+<.01%) compared to c2c5bfc
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mauriciofauth

This comment has been minimized.

Show comment
Hide comment
@mauriciofauth

mauriciofauth Jul 13, 2018

Member

Merged, thanks for your contribution!

Member

mauriciofauth commented Jul 13, 2018

Merged, thanks for your contribution!

@mauriciofauth mauriciofauth self-assigned this Jul 13, 2018

@mauriciofauth mauriciofauth added this to the 5.0.0 milestone Jul 13, 2018

@laps15 laps15 deleted the laps15:inheritance branch Jul 18, 2018

@williamdes

This comment has been minimized.

Show comment
Hide comment
@williamdes

williamdes Jul 21, 2018

Member

@mauriciofauth @laps15
phpstan reported :

 ------ ---------------------------------------------------------------------------------------- 
  Line   libraries/classes/Controllers/Table/TableRelationController.php                         
 ------ ---------------------------------------------------------------------------------------- 
  192    Array has 2 duplicate keys with value 'cfg_relation' ('cfg_relation', 'cfg_relation').  
  192    Array has 2 duplicate keys with value 'url_params' ('url_params', 'url_params').        
 ------ ----------------------------------------------------------------------------------------
Member

williamdes commented Jul 21, 2018

@mauriciofauth @laps15
phpstan reported :

 ------ ---------------------------------------------------------------------------------------- 
  Line   libraries/classes/Controllers/Table/TableRelationController.php                         
 ------ ---------------------------------------------------------------------------------------- 
  192    Array has 2 duplicate keys with value 'cfg_relation' ('cfg_relation', 'cfg_relation').  
  192    Array has 2 duplicate keys with value 'url_params' ('url_params', 'url_params').        
 ------ ----------------------------------------------------------------------------------------

mauriciofauth added a commit that referenced this pull request Jul 27, 2018

Refactor table relation's templates (#14490)
* Fix secondary tabs bug
* Refactor table relation's templates
* Fix phpstan error report mentioned on pr #14483

Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment