New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor table relation's templates #14490

Merged
merged 3 commits into from Jul 27, 2018

Conversation

Projects
None yet
4 participants
@laps15
Contributor

laps15 commented Jul 18, 2018

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Jul 23, 2018

Codecov Report

Merging #14490 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master   #14490      +/-   ##
============================================
- Coverage     50.44%   50.44%   -0.01%     
  Complexity    14430    14430              
============================================
  Files           500      500              
  Lines         67841    67842       +1     
============================================
  Hits          34220    34220              
- Misses        33621    33622       +1

codecov bot commented Jul 23, 2018

Codecov Report

Merging #14490 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master   #14490      +/-   ##
============================================
- Coverage     50.44%   50.44%   -0.01%     
  Complexity    14430    14430              
============================================
  Files           500      500              
  Lines         67841    67842       +1     
============================================
  Hits          34220    34220              
- Misses        33621    33622       +1
@@ -210,13 +210,10 @@ public function indexAction()
'url_params' => $GLOBALS['url_params'],

This comment has been minimized.

@williamdes
@williamdes

laps15 added some commits Jul 18, 2018

Fix secondary tabs bug
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
Refactor table relation's templates
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
@phpmyadmin-bot

This comment has been minimized.

Show comment
Hide comment
@phpmyadmin-bot

phpmyadmin-bot Jul 24, 2018

This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: templates/table/relation/common_form.twig

phpmyadmin-bot commented on a017a8e Jul 24, 2018

This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: templates/table/relation/common_form.twig

Fix phpstan error report mentioned on pr#14483
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>

@williamdes williamdes referenced this pull request Jul 27, 2018

Merged

phpstan level 1 #14472

@mauriciofauth mauriciofauth merged commit 669b8a5 into phpmyadmin:master Jul 27, 2018

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
DCO All commits have a DCO sign-off from the author
Details
Scrutinizer Analysis: 1 updated code elements – Tests: passed
Details
@mauriciofauth

This comment has been minimized.

Show comment
Hide comment
@mauriciofauth

mauriciofauth Jul 27, 2018

Member

Merged, thanks for your contribution!

Member

mauriciofauth commented Jul 27, 2018

Merged, thanks for your contribution!

@mauriciofauth mauriciofauth self-assigned this Jul 27, 2018

@mauriciofauth mauriciofauth added this to the 5.0.0 milestone Jul 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment