New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modular code for Database Structure and some other database related files #14533

Merged
merged 12 commits into from Aug 19, 2018

Conversation

Projects
None yet
3 participants
@Piyush3079
Contributor

Piyush3079 commented Jul 29, 2018

This pr contains the modular code for files DB_Structure, DB_Operations and Db_central_columns.
One FileHandler is also added to handle loading of files.

This pr is in continuation of Mod_Js_Sql_Profiling. Before reviewing this pr, review and merge Mod_Js_Sql_Profiling.

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
@phpmyadmin-bot

This comment has been minimized.

Show comment
Hide comment
@phpmyadmin-bot

phpmyadmin-bot Jul 29, 2018

This pull requests contains too many commits, in most cases it is caused by wrong merge target. In case you have forked master branch you should also ask merging to master branch. See GitHub documentation for more details.

phpmyadmin-bot commented Jul 29, 2018

This pull requests contains too many commits, in most cases it is caused by wrong merge target. In case you have forked master branch you should also ask merging to master branch. See GitHub documentation for more details.

@phpmyadmin-bot

This comment has been minimized.

Show comment
Hide comment
@phpmyadmin-bot

phpmyadmin-bot Jul 29, 2018

This pull requests contains too many commits, in most cases it is caused by wrong merge target. In case you have forked master branch you should also ask merging to master branch. See GitHub documentation for more details.

phpmyadmin-bot commented Jul 29, 2018

This pull requests contains too many commits, in most cases it is caused by wrong merge target. In case you have forked master branch you should also ask merging to master branch. See GitHub documentation for more details.

@phpmyadmin-bot

This comment has been minimized.

Show comment
Hide comment
@phpmyadmin-bot

phpmyadmin-bot Jul 29, 2018

This pull requests contains too many commits, in most cases it is caused by wrong merge target. In case you have forked master branch you should also ask merging to master branch. See GitHub documentation for more details.

phpmyadmin-bot commented Jul 29, 2018

This pull requests contains too many commits, in most cases it is caused by wrong merge target. In case you have forked master branch you should also ask merging to master branch. See GitHub documentation for more details.

@devenbansod devenbansod self-requested a review Aug 16, 2018

@devenbansod devenbansod self-assigned this Aug 16, 2018

@devenbansod

This comment has been minimized.

Show comment
Hide comment
@devenbansod

devenbansod Aug 16, 2018

Member

@Piyush3079 please rebase

Member

devenbansod commented Aug 16, 2018

@Piyush3079 please rebase

Piyush3079 added some commits May 14, 2018

Add db_structure.js in modular code.
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
Bug fix for ajax server side error.
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
Add prepare_ajax_request and preview_sql to modular code.
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
Add CreateTable and TableColumns module for adding table in db_struct…
…ure.php.

Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
Edit js/src/functions.js to add functions required for create table i…
…n db_structure.php.

Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
Add db_operations.js to modular code.
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
Create FileHandler class to manage loading of files on the basis of p…
…age and on the basis of user preferences.

Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
Add db_tracking.js for tracking tables of database in modular code.
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
Add central columns to the modular code.
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
Replace .js extension from db_export and db_import.
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
Resolve merge conflicts and some code cleanup for functions.js
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Aug 17, 2018

Codecov Report

Merging #14533 into gsoc-js-refactoring will decrease coverage by <.01%.
The diff coverage is 0%.

@@                    Coverage Diff                    @@
##             gsoc-js-refactoring   #14533      +/-   ##
=========================================================
- Coverage                  50.57%   50.57%   -0.01%     
- Complexity                 14439    14442       +3     
=========================================================
  Files                        501      501              
  Lines                      67990    67999       +9     
=========================================================
  Hits                       34388    34388              
- Misses                     33602    33611       +9

codecov bot commented Aug 17, 2018

Codecov Report

Merging #14533 into gsoc-js-refactoring will decrease coverage by <.01%.
The diff coverage is 0%.

@@                    Coverage Diff                    @@
##             gsoc-js-refactoring   #14533      +/-   ##
=========================================================
- Coverage                  50.57%   50.57%   -0.01%     
- Complexity                 14439    14442       +3     
=========================================================
  Files                        501      501              
  Lines                      67990    67999       +9     
=========================================================
  Hits                       34388    34388              
- Misses                     33602    33611       +9

@Piyush3079 Piyush3079 changed the title from Mod js db structure to Modular code for Database Structure and some other database related files Aug 17, 2018

Bug fix for multi table actions on db_structure.php
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
@devenbansod

Tested locally. LGTM.

Nice work on this.

@devenbansod devenbansod merged commit 0c34115 into phpmyadmin:gsoc-js-refactoring Aug 19, 2018

1 of 3 checks passed

Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
DCO All commits have a DCO sign-off from the author
Details

@Piyush3079 Piyush3079 deleted the Piyush3079:Mod_Js_Db_Structure branch Aug 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment