Fix for SYSTEM VERSIONED tables #14514, #14515, and #14516 #14536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincent Milum Jr <git@darkain.com>
Signed-off-by: Vincent Milum Jr <git@darkain.com>
…er params Signed-off-by: Vincent Milum Jr <git@darkain.com>
Signed-off-by: Vincent Milum Jr <git@darkain.com>
darkain
changed the title
williamdes
approved these changes
Sep 13, 2018
MauricioFauth
approved these changes
Oct 28, 2018
MauricioFauth
requested changes
Oct 29, 2018
Member
MauricioFauth
left a comment
MauricioFauth
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
I don't know why Travis CI didn't run, but you also need to fix the failing tests.
Co-Authored-By: darkain <git@darkain.com>
Co-Authored-By: darkain <git@darkain.com>
Co-Authored-By: darkain <git@darkain.com>
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Member
|
Merged, thanks for your contribution! |
MauricioFauth
pushed a commit
that referenced
this pull request
Feb 15, 2019
Fixes #14514 Fixes #14515 Possible fix for #14516 #14514 Tables which enable the new MariaDB 10.3 versioning show up as "SYSTEM VERSIONED" instead of "BASE TABLE" inside of information schema. This patch now checks for both, so these new table types don't incorrectly display as views. #14515 MariaDB 10.3 also supports INVISIBLE columns, which is optionally paired with SYSTEM VERSIONED tabled (or implemented separately). This patch helps handle this new column attribute. #14516 This patch cannot be fully tested and verified with current MariaDB builds. Version 10.3.9 (currently unreleased) corrects an issue with column information for SYSTEM VERSIONED columns that this patch relies on. https://jira.mariadb.org/browse/MDEV-16804 - the reason for checking with preg_match instead of adding to the list is because there are now combined "extra" information for columns, such as INVISIBLE columns. Just matching entire strings also has a bug with these other "extra" parameters. Signed-off-by: Vincent Milum Jr <git@darkain.com> Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com> (cherry picked from commit 3f6e360) Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
MauricioFauth
added a commit
that referenced
this pull request
Feb 24, 2019
Related to #14536 Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14514
Fixes #14515
Possible fix for #14516
#14514 Tables which enable the new MariaDB 10.3 versioning show up as "SYSTEM VERSIONED" instead of "BASE TABLE" inside of information schema. This patch now checks for both, so these new table types don't incorrectly display as views.
#14515 MariaDB 10.3 also supports INVISIBLE columns, which is optionally paired with SYSTEM VERSIONED tabled (or implemented separately). This patch helps handle this new column attribute.
#14516 This patch cannot be fully tested and verified with current MariaDB builds. Version 10.3.9 (currently unreleased) corrects an issue with column information for SYSTEM VERSIONED columns that this patch relies on. https://jira.mariadb.org/browse/MDEV-16804 - the reason for checking with preg_match instead of adding to the list is because there are now combined "extra" information for columns, such as INVISIBLE columns. Just matching entire strings also has a bug with these other "extra" parameters.
Before submitting pull request, please check that every commit: