Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for SYSTEM VERSIONED tables #14514, #14515, and #14516 #14536

Merged
merged 8 commits into from Feb 15, 2019
Merged

Fix for SYSTEM VERSIONED tables #14514, #14515, and #14516 #14536

merged 8 commits into from Feb 15, 2019

Conversation

darkain
Copy link
Contributor

@darkain darkain commented Jul 31, 2018

Fixes #14514
Fixes #14515
Possible fix for #14516

#14514 Tables which enable the new MariaDB 10.3 versioning show up as "SYSTEM VERSIONED" instead of "BASE TABLE" inside of information schema. This patch now checks for both, so these new table types don't incorrectly display as views.

#14515 MariaDB 10.3 also supports INVISIBLE columns, which is optionally paired with SYSTEM VERSIONED tabled (or implemented separately). This patch helps handle this new column attribute.

#14516 This patch cannot be fully tested and verified with current MariaDB builds. Version 10.3.9 (currently unreleased) corrects an issue with column information for SYSTEM VERSIONED columns that this patch relies on. https://jira.mariadb.org/browse/MDEV-16804 - the reason for checking with preg_match instead of adding to the list is because there are now combined "extra" information for columns, such as INVISIBLE columns. Just matching entire strings also has a bug with these other "extra" parameters.

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

darkain and others added 4 commits July 31, 2018 10:26
Signed-off-by: Vincent Milum Jr <git@darkain.com>
Signed-off-by: Vincent Milum Jr <git@darkain.com>
…er params

Signed-off-by: Vincent Milum Jr <git@darkain.com>
Signed-off-by: Vincent Milum Jr <git@darkain.com>
@darkain darkain changed the title Fix for SYSTEM VERSIONED tables #14514, maybe #14516 Fix for SYSTEM VERSIONED tables #14514, #14515, and #14516 Aug 1, 2018
Copy link
Member

@MauricioFauth MauricioFauth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!
I don't know why Travis CI didn't run, but you also need to fix the failing tests.

libraries/classes/Dbi/DbiMysqli.php Outdated Show resolved Hide resolved
libraries/classes/Dbi/DbiMysqli.php Outdated Show resolved Hide resolved
libraries/classes/Dbi/DbiMysqli.php Outdated Show resolved Hide resolved
MauricioFauth and others added 3 commits November 5, 2018 15:23
Co-Authored-By: darkain <git@darkain.com>
Co-Authored-By: darkain <git@darkain.com>
Co-Authored-By: darkain <git@darkain.com>
@stale
Copy link

stale bot commented Jan 19, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added wontfix and removed wontfix labels Jan 19, 2019
@MauricioFauth MauricioFauth merged commit 3f6e360 into phpmyadmin:master Feb 15, 2019
@MauricioFauth MauricioFauth self-assigned this Feb 15, 2019
@MauricioFauth
Copy link
Member

Merged, thanks for your contribution!

MauricioFauth pushed a commit that referenced this pull request Feb 15, 2019
Fixes #14514
Fixes #14515
Possible fix for #14516

 #14514 Tables which enable the new MariaDB 10.3 versioning show up as "SYSTEM VERSIONED" instead of "BASE TABLE" inside of information schema. This patch now checks for both, so these new table types don't incorrectly display as views.

 #14515 MariaDB 10.3 also supports INVISIBLE columns, which is optionally paired with SYSTEM VERSIONED tabled (or implemented separately). This patch helps handle this new column attribute.

 #14516 This patch cannot be fully tested and verified with current MariaDB builds. Version 10.3.9 (currently unreleased) corrects an issue with column information for SYSTEM VERSIONED columns that this patch relies on. https://jira.mariadb.org/browse/MDEV-16804 - the reason for checking with preg_match instead of adding to the list is because there are now combined "extra" information for columns, such as INVISIBLE columns. Just matching entire strings also has a bug with these other "extra" parameters.

Signed-off-by: Vincent Milum Jr <git@darkain.com>
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
(cherry picked from commit 3f6e360)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@MauricioFauth MauricioFauth added this to the 4.8.6 milestone Feb 15, 2019
MauricioFauth added a commit that referenced this pull request Feb 24, 2019
Related to #14536

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants