New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor extensions #14541

Merged
merged 16 commits into from Aug 4, 2018

Conversation

Projects
None yet
2 participants
@laps15
Contributor

laps15 commented Aug 2, 2018

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Aug 2, 2018

Codecov Report

Merging #14541 into master will decrease coverage by <.01%.
The diff coverage is 96.29%.

@@             Coverage Diff              @@
##             master   #14541      +/-   ##
============================================
- Coverage     50.05%   50.04%   -0.01%     
  Complexity    14434    14434              
============================================
  Files           500      498       -2     
  Lines         67340    67329      -11     
============================================
- Hits          33705    33693      -12     
- Misses        33635    33636       +1

codecov bot commented Aug 2, 2018

Codecov Report

Merging #14541 into master will decrease coverage by <.01%.
The diff coverage is 96.29%.

@@             Coverage Diff              @@
##             master   #14541      +/-   ##
============================================
- Coverage     50.05%   50.04%   -0.01%     
  Complexity    14434    14434              
============================================
  Files           500      498       -2     
  Lines         67340    67329      -11     
============================================
- Hits          33705    33693      -12     
- Misses        33635    33636       +1

@mauriciofauth mauriciofauth self-assigned this Aug 2, 2018

@mauriciofauth mauriciofauth added this to the 5.0.0 milestone Aug 2, 2018

laps15 added some commits Jul 27, 2018

Rename charsets Twig extensions
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
Rename core Twig's extension
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
Remove index Twig extensions
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
Rename message Twig extensions
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
Remove partition Twig extensions
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
Rename plugins Twig extensions
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
Rename relations Twig extensions
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
Rename ServerPrivileges Twig extension
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
Rename StorageEngine Twig extensions
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
Rename table Twig extension
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
Rename tracker Twig extension
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
Rename Transformation Twig extensions
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
Refactor Url Twig extensions
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
Refactor Util Twig extensions
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
Refactor Sanitize Twig extensions
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
Addapt for master merge
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>

@mauriciofauth mauriciofauth merged commit b046246 into phpmyadmin:master Aug 4, 2018

6 of 7 checks passed

codeclimate 2 issues to fix
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
DCO All commits have a DCO sign-off from the author
Details
Scrutinizer Analysis: 5 updated code elements – Tests: passed
Details
codecov/patch 96.29% of diff hit (target 50.05%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +46.24% compared to bdecea6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mauriciofauth

This comment has been minimized.

Show comment
Hide comment
@mauriciofauth

mauriciofauth Aug 4, 2018

Member

Merged, thanks for your contribution!

Member

mauriciofauth commented Aug 4, 2018

Merged, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment