Add initial support for Bootstrap 4 #14765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamdes
approved these changes
Dec 2, 2018
devenbansod
approved these changes
Dec 2, 2018
There was a problem hiding this comment.
LGTM 💯
Thanks @MauricioFauth for taking this up. This definitely seems like a step in right direction! 👍
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
MauricioFauth
force-pushed
the
bootstrap
branch
from
8fc1744
to
2dc9f4c
Compare
Codecov Report
@@ Coverage Diff @@
## master #14765 +/- ##
============================================
- Coverage 50.96% 50.92% -0.05%
+ Complexity 14028 14021 -7
============================================
Files 473 473
Lines 65313 65300 -13
============================================
- Hits 33288 33254 -34
- Misses 32025 32046 +21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When implementing Sass, I noticed some inconsistencies in phpMyAdmin's CSS and UI, some of these inconsistencies were described in #14237.
Thinking about this, a good way to solve this would be to adopt a CSS framework, as this would be like a CSS guideline (#14237). Another advantage is that a theme developed for this framework would be easily adaptable to phpMyAdmin.
So, I think it would be interesting to use Bootstrap because, in addition to being one of the most popular, we already use it in the Website and in the Error Reporting Server.
Bootstrap 4.1.3 has approximately 141 kB in size when minified.
The idea is to refactor part by part, until we have the entire layout redone with Bootstrap.
Related to #11392, #13004, #13036, #13077, #13773 and #14237