Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Bookmark::get() id matching SQL #14843

Merged
merged 1 commit into from Mar 6, 2019

Conversation

miklcct
Copy link
Contributor

@miklcct miklcct commented Jan 11, 2019

Description

fix a mistake in SQL which causes default bookmark not working in 4.7 or above

Before submitting pull request, please review the following checklist:

  • [*] Make sure you have read our CONTRIBUTING.md document.
  • [*] Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • [*] Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • [*] Every commit has a descriptive commit message.
  • [*] Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • [*] Any new functionality is covered by tests.

fix a mistake in SQL which causes default bookmark not working

Signed-off-by: Michael Tsang <miklcct@gmail.com>
@codecov
Copy link

codecov bot commented Jan 11, 2019

Codecov Report

Merging #14843 into QA_4_8 will not change coverage.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             QA_4_8   #14843   +/-   ##
=========================================
  Coverage     55.69%   55.69%           
  Complexity    14441    14441           
=========================================
  Files           494      494           
  Lines         70854    70854           
=========================================
  Hits          39464    39464           
  Misses        31390    31390

1 similar comment
@codecov
Copy link

codecov bot commented Jan 11, 2019

Codecov Report

Merging #14843 into QA_4_8 will not change coverage.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             QA_4_8   #14843   +/-   ##
=========================================
  Coverage     55.69%   55.69%           
  Complexity    14441    14441           
=========================================
  Files           494      494           
  Lines         70854    70854           
=========================================
  Hits          39464    39464           
  Misses        31390    31390

@MauricioFauth MauricioFauth merged commit b36ae1b into phpmyadmin:QA_4_8 Mar 6, 2019
@MauricioFauth MauricioFauth added this to the 4.8.6 milestone Mar 6, 2019
@MauricioFauth MauricioFauth self-assigned this Mar 6, 2019
@MauricioFauth
Copy link
Member

Merged, thanks for your contribution!

MauricioFauth added a commit that referenced this pull request Mar 6, 2019
[ci skip]

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants