Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title for group in navigation bar #14977

Closed
wants to merge 1 commit into from

Conversation

bahl24
Copy link
Contributor

@bahl24 bahl24 commented Feb 25, 2019

Signed-off-by: Nitish Bahl nitishbahl24@gmail.com

Description- Added title for group in database in nav bar

Please describe your pull request.
grp

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.

Signed-off-by: Nitish Bahl <nitishbahl24@gmail.com>
@codecov
Copy link

codecov bot commented Feb 25, 2019

Codecov Report

Merging #14977 into QA_4_8 will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             QA_4_8   #14977      +/-   ##
============================================
- Coverage     55.68%   55.68%   -0.01%     
  Complexity    14448    14448              
============================================
  Files           494      494              
  Lines         70869    70870       +1     
============================================
  Hits          39466    39466              
- Misses        31403    31404       +1

@williamdes
Copy link
Member

@ibennetch Master or QA ?

Copy link
Member

@MauricioFauth MauricioFauth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is an enhancement, it should target the master branch.

@bahl24
Copy link
Contributor Author

bahl24 commented Apr 4, 2019 via email

@MauricioFauth MauricioFauth changed the title added title for group in nav bar Add title for group in navigation bar May 4, 2019
@MauricioFauth MauricioFauth self-assigned this May 4, 2019
@MauricioFauth MauricioFauth added this to the 5.0.0 milestone May 4, 2019
@MauricioFauth
Copy link
Member

Merged, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants