Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move 'More settings' link from 'Appearance settings' to 'General settings' #15030

Merged
merged 1 commit into from Mar 18, 2019

Conversation

MauricioFauth
Copy link
Member

Description

Moves More settings link from Appearance settings group to General settings group on index.php.

As More settings is a link to the user preferences, I think it is more coherent to move this link to General settings.

Before

Screenshot from 2019-03-15 21-34-15

After

Screenshot from 2019-03-15 21-34-49

…ings'

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
@codecov
Copy link

codecov bot commented Mar 16, 2019

Codecov Report

Merging #15030 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #15030   +/-   ##
=========================================
  Coverage     52.83%   52.83%           
  Complexity    14026    14026           
=========================================
  Files           479      479           
  Lines         62652    62652           
=========================================
  Hits          33104    33104           
  Misses        29548    29548

1 similar comment
@codecov
Copy link

codecov bot commented Mar 16, 2019

Codecov Report

Merging #15030 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #15030   +/-   ##
=========================================
  Coverage     52.83%   52.83%           
  Complexity    14026    14026           
=========================================
  Files           479      479           
  Lines         62652    62652           
=========================================
  Hits          33104    33104           
  Misses        29548    29548

@MauricioFauth MauricioFauth merged commit 2910b58 into phpmyadmin:master Mar 18, 2019
@MauricioFauth MauricioFauth deleted the more-settings branch March 18, 2019 17:24
@MauricioFauth MauricioFauth self-assigned this Mar 18, 2019
@MauricioFauth MauricioFauth added this to the 5.0.0 milestone Mar 18, 2019
@ibennetch
Copy link
Member

ibennetch commented Mar 18, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants