Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Login and Home page layout to Bootstrap #15298

Closed
wants to merge 4 commits into from

Conversation

@murex971
Copy link
Contributor

@murex971 murex971 commented Jun 1, 2019

Description

implementation of Bootstrap

@shucon
Copy link
Contributor

@shucon shucon commented Jun 1, 2019

Please try to use better commit message and sign-off each commit.

Loading

@@ -184,6 +185,6 @@
</ul>
</div>
</div>
</div>
</div></div></div>
Copy link
Contributor

@shucon shucon Jun 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proper indentation of closing tags, and each tag in new line is required.

Loading

@@ -2,6 +2,8 @@
<div id="modalOverlay">
{% endif %}
<div class="container{{ add_class }}">
<div class="row">
<div class="col-12">
Copy link
Contributor

@shucon shucon Jun 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing tags for them are not present.

Loading

@mauriciofauth mauriciofauth changed the base branch from master to gsoc-bootstrap Jun 1, 2019
@mauriciofauth mauriciofauth changed the title first commit Convert Login and Home page layout to Bootstrap Jun 1, 2019
Copy link
Member

@mauriciofauth mauriciofauth left a comment

Nice work!

You should try to keep the style of the themes (pmahomme, Metro and Original) as same as possible.
For example, the login page is looking different:
Screenshot from 2019-06-01 14-50-38

Loading

@mauriciofauth mauriciofauth self-assigned this Jun 1, 2019
Copy link
Member

@mauriciofauth mauriciofauth left a comment

Also, don't forget to add your signature tag in the commit messages with git commit -s.

Loading

mauriciofauth and others added 4 commits Jun 2, 2019
As of jQuery 3.0, .bind() has been deprecated.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
Inject dependencies instead of building them.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
External dependency injection system

[ci skip]

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
@murex971
Copy link
Contributor Author

@murex971 murex971 commented Jun 2, 2019

Nice work!

You should try to keep the style of the themes (pmahomme, Metro and Original) as same as possible.
For example, the login page is looking different:
Screenshot from 2019-06-01 14-50-38

I will be working on forms particularly once I am done with the grids part.

Loading

@murex971 murex971 marked this pull request as ready for review Jun 2, 2019
@codecov
Copy link

@codecov codecov bot commented Jun 2, 2019

Codecov Report

Merging #15298 into gsoc-bootstrap will decrease coverage by 0.03%.
The diff coverage is 26.87%.

@@                 Coverage Diff                  @@
##             gsoc-bootstrap   #15298      +/-   ##
====================================================
- Coverage             52.76%   52.72%   -0.04%     
- Complexity            14068    14071       +3     
====================================================
  Files                   484      484              
  Lines                 62214    62135      -79     
====================================================
- Hits                  32826    32762      -64     
+ Misses                29388    29373      -15

Loading

@mauriciofauth
Copy link
Member

@mauriciofauth mauriciofauth commented Jun 6, 2019

Closed in favor of #15302

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants