Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Login and Home page layout to Bootstrap #15298

Closed
wants to merge 4 commits into from

Conversation

Projects
None yet
5 participants
@murex971
Copy link
Contributor

commented Jun 1, 2019

Description

implementation of Bootstrap

@murex971 murex971 force-pushed the murex971:master branch from 518be36 to 16786d6 Jun 1, 2019

@shucon

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2019

Please try to use better commit message and sign-off each commit.

@@ -184,6 +185,6 @@
</ul>
</div>
</div>
</div>
</div></div></div>

This comment has been minimized.

Copy link
@shucon

shucon Jun 1, 2019

Contributor

Proper indentation of closing tags, and each tag in new line is required.

@@ -2,6 +2,8 @@
<div id="modalOverlay">
{% endif %}
<div class="container{{ add_class }}">
<div class="row">
<div class="col-12">

This comment has been minimized.

Copy link
@shucon

shucon Jun 1, 2019

Contributor

Closing tags for them are not present.

@mauriciofauth mauriciofauth changed the base branch from master to gsoc-bootstrap Jun 1, 2019

@mauriciofauth mauriciofauth changed the title first commit Convert Login and Home page layout to Bootstrap Jun 1, 2019

@mauriciofauth
Copy link
Member

left a comment

Nice work!

You should try to keep the style of the themes (pmahomme, Metro and Original) as same as possible.
For example, the login page is looking different:
Screenshot from 2019-06-01 14-50-38

@mauriciofauth mauriciofauth self-assigned this Jun 1, 2019

@mauriciofauth
Copy link
Member

left a comment

Also, don't forget to add your signature tag in the commit messages with git commit -s.

mauriciofauth and others added some commits May 31, 2019

Replace jQuery .bind() with .on()
As of jQuery 3.0, .bind() has been deprecated.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
first commit
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
Inject dependencies (#15271)
Inject dependencies instead of building them.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
Add ChangeLog entry for #15266
External dependency injection system

[ci skip]

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>

@murex971 murex971 force-pushed the murex971:master branch from f10e03f to 693f324 Jun 2, 2019

@phpmyadmin-bot

This comment has been minimized.

Copy link

commented on 0a6c043 Jun 2, 2019

This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: templates/home/index.twig

@murex971

This comment has been minimized.

Copy link
Contributor Author

commented Jun 2, 2019

Nice work!

You should try to keep the style of the themes (pmahomme, Metro and Original) as same as possible.
For example, the login page is looking different:
Screenshot from 2019-06-01 14-50-38

I will be working on forms particularly once I am done with the grids part.

@murex971 murex971 marked this pull request as ready for review Jun 2, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 2, 2019

Codecov Report

Merging #15298 into gsoc-bootstrap will decrease coverage by 0.03%.
The diff coverage is 26.87%.

@@                 Coverage Diff                  @@
##             gsoc-bootstrap   #15298      +/-   ##
====================================================
- Coverage             52.76%   52.72%   -0.04%     
- Complexity            14068    14071       +3     
====================================================
  Files                   484      484              
  Lines                 62214    62135      -79     
====================================================
- Hits                  32826    32762      -64     
+ Misses                29388    29373      -15
@mauriciofauth

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

Closed in favor of #15302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.