Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables grid #15302

Merged
merged 7 commits into from Jun 6, 2019
Merged

Variables grid #15302

merged 7 commits into from Jun 6, 2019

Conversation

@murex971
Copy link
Contributor

@murex971 murex971 commented Jun 4, 2019

this adds the basic grid structure to variables page.

mauriciofauth and others added 4 commits Jun 2, 2019
As of jQuery 3.0, .bind() has been deprecated.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
Inject dependencies instead of building them.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
External dependency injection system

[ci skip]

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
murex971 added 2 commits Jun 2, 2019
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
@mauriciofauth mauriciofauth changed the base branch from master to gsoc-bootstrap Jun 4, 2019
@codecov
Copy link

@codecov codecov bot commented Jun 4, 2019

Codecov Report

Merging #15302 into gsoc-bootstrap will decrease coverage by 0.06%.
The diff coverage is 27.32%.

@@                 Coverage Diff                  @@
##             gsoc-bootstrap   #15302      +/-   ##
====================================================
- Coverage             52.76%    52.7%   -0.07%     
- Complexity            14068    14088      +20     
====================================================
  Files                   484      484              
  Lines                 62214    62368     +154     
====================================================
+ Hits                  32826    32868      +42     
- Misses                29388    29500     +112

Loading

1 similar comment
@codecov
Copy link

@codecov codecov bot commented Jun 4, 2019

Codecov Report

Merging #15302 into gsoc-bootstrap will decrease coverage by 0.06%.
The diff coverage is 27.32%.

@@                 Coverage Diff                  @@
##             gsoc-bootstrap   #15302      +/-   ##
====================================================
- Coverage             52.76%    52.7%   -0.07%     
- Complexity            14068    14088      +20     
====================================================
  Files                   484      484              
  Lines                 62214    62368     +154     
====================================================
+ Hits                  32826    32868      +42     
- Misses                29388    29500     +112

Loading

@mauriciofauth mauriciofauth merged commit 200e709 into phpmyadmin:gsoc-bootstrap Jun 6, 2019
3 of 7 checks passed
Loading
@mauriciofauth mauriciofauth mentioned this pull request Jun 6, 2019
@mauriciofauth mauriciofauth self-assigned this Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants