Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables grid #15302

Merged
merged 7 commits into from Jun 6, 2019

Conversation

@murex971
Copy link
Contributor

commented Jun 4, 2019

this adds the basic grid structure to variables page.

mauriciofauth and others added 4 commits May 31, 2019
Replace jQuery .bind() with .on()
As of jQuery 3.0, .bind() has been deprecated.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
first commit
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
Inject dependencies (#15271)
Inject dependencies instead of building them.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
Add ChangeLog entry for #15266
External dependency injection system

[ci skip]

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
@phpmyadmin-bot

This comment has been minimized.

Copy link

commented on 0a6c043 Jun 2, 2019

This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: templates/home/index.twig

fixes indentation and tags
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
@phpmyadmin-bot

This comment has been minimized.

Copy link

commented on 3c27ee7 Jun 2, 2019

This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: templates/home/index.twig

murex971 added 2 commits Jun 2, 2019
bootstrap grid applied to plugin page
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
applied grid structure to variables page
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
@phpmyadmin-bot

This comment has been minimized.

Copy link

commented on 619705b Jun 4, 2019

This commit is using tab character for indentation instead of spaces, what is mandated by phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: templates/filter.twig

@mauriciofauth mauriciofauth changed the base branch from master to gsoc-bootstrap Jun 4, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 4, 2019

Codecov Report

Merging #15302 into gsoc-bootstrap will decrease coverage by 0.06%.
The diff coverage is 27.32%.

@@                 Coverage Diff                  @@
##             gsoc-bootstrap   #15302      +/-   ##
====================================================
- Coverage             52.76%    52.7%   -0.07%     
- Complexity            14068    14088      +20     
====================================================
  Files                   484      484              
  Lines                 62214    62368     +154     
====================================================
+ Hits                  32826    32868      +42     
- Misses                29388    29500     +112
1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Jun 4, 2019

Codecov Report

Merging #15302 into gsoc-bootstrap will decrease coverage by 0.06%.
The diff coverage is 27.32%.

@@                 Coverage Diff                  @@
##             gsoc-bootstrap   #15302      +/-   ##
====================================================
- Coverage             52.76%    52.7%   -0.07%     
- Complexity            14068    14088      +20     
====================================================
  Files                   484      484              
  Lines                 62214    62368     +154     
====================================================
+ Hits                  32826    32868      +42     
- Misses                29388    29500     +112

@mauriciofauth mauriciofauth merged commit 200e709 into phpmyadmin:gsoc-bootstrap Jun 6, 2019

3 of 7 checks passed

Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
codeclimate 3 issues to fix
Details
codecov/patch 27.32% of diff hit (target 52.76%)
Details
codecov/project 52.7% (-0.07%) compared to c8dd866
Details
DCO DCO
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mauriciofauth mauriciofauth self-assigned this Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.